Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Added ability to scroll Tab groups bar icons on swipe #11939

Merged
merged 1 commit into from
Jan 21, 2022
Merged

[Android] Added ability to scroll Tab groups bar icons on swipe #11939

merged 1 commit into from
Jan 21, 2022

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Jan 20, 2022 •
edited
Loading

Resolves brave/brave-browser#19902

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 20, 2022
@samartnik samartnik added this to the 1.36.x - Nightly milestone Jan 20, 2022
@samartnik samartnik self-assigned this Jan 20, 2022
SergeyZhukovsky
SergeyZhukovsky approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit 730cb19 into master Jan 21, 2022
@samartnik samartnik deleted the android_tab_groups_bar_swipe branch January 21, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees

@samartnik samartnik

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging this pull request may close these issues.

Add ability to scroll Tab groups bar icons on swipe
2 participants
@samartnik @SergeyZhukovsky