Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Reusable GetBlockExplorerUrl Util #20192

Closed
Douglashdaniel opened this issue Dec 21, 2021 · 2 comments · Fixed by brave/brave-core#11685
Closed

Create a Reusable GetBlockExplorerUrl Util #20192

Douglashdaniel opened this issue Dec 21, 2021 · 2 comments · Fixed by brave/brave-core#11685
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Dec 21, 2021

Description

Currently we have multiple methods through out the wallet for getting an EthereumChain block explorer URL.
We should create a reusable GetBlockExplorerUrl util to cut down on duplicated code.

Test plan

No functional change, so the test plan is to ensure block explorer links work correctly (see Demo in linked PR for an example).

  • Should be able to view addresses, transactions, and contracts (whenever relevant).
  • Should be able to open block explorer links both from Wallet page as well as panel.
  • Should be able to open block explorer links for custom networks, such as Polygon.
@bbondy
Copy link
Member

bbondy commented Dec 28, 2021

Posted a follow up for this here #20246

@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2022

Brave 1.35.98 Chromium: 98.0.4758.72 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified able to view addresses, transactions, and contracts
  • Verified able to open block explorer links both from Wallet page as well as panel
  • Verified able to open block explorer links for custom networks, such as Polygon
20192-Linux.mp4
20192-Windows.mov
20192-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants