Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a learn more link on Safe Browsing setting to our support page #20514

Closed
fmarier opened this issue Jan 15, 2022 · 7 comments · Fixed by brave/brave-core#12696 or brave/brave-core#18324

Comments

@fmarier
Copy link
Member

fmarier commented Jan 15, 2022

We now have a section about Safe Browsing in our privacy policy: https://brave.com/privacy/browser/#safe-browsing

We should link to it from brave://settings/security on desktop:
Screenshot from 2022-01-14 16-33-10

and from Settings | Brave Shiels & privacy | Safe Browsing on Android:
Screenshot_20220114-162951

I don't know whether this needs input from the design team, but for Desktop, I was thinking of a "Learn more" link like this one:
Screenshot from 2022-01-14 16-38-53

and for Android, perhaps we could simply change what the (?) button in the top-right corner links to? Right now, it links to community.brave.com which seems extremely generic and not particularly useful in this context.

@fmarier
Copy link
Member Author

fmarier commented Apr 29, 2023

Instead of our privacy policy, this should link to https://support.brave.com/hc/en-us/articles/15222663599629-Safe-Browsing-in-Brave.

@fmarier fmarier self-assigned this Apr 29, 2023
@fmarier fmarier changed the title Add a learn more link on Safe Browsing setting to our privacy policy Add a learn more link on Safe Browsing setting to our support page May 1, 2023
@fmarier
Copy link
Member Author

fmarier commented May 1, 2023

Safe Browsing intersitials currently link to the Google support page and so should be updated to point to our page instead.

@stephendonner
Copy link

stephendonner commented May 17, 2023

Verified PASSED using

Brave 1.53.45 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 11.7.6 (Build 20G1231)

Steps:

  1. installed 1.53.45
  2. launched Brave
  3. waited for 5 minutes
  4. loaded https://testsafebrowsing.appspot.com/s/malware.html
  5. confirmed interstitial page (and clicked Details)
  6. confirmed Learn more link opened https://support.brave.com/hc/en-us/articles/15222663599629-Safe-Browsing-in-Brave in a new tab
  7. loaded https://testsafebrowsing.appspot.com/s/malware.html
  8. clicked on Back to safety
  9. confirmed it opened the new-tab page
  10. opened brave://settings/security and clicked on the (?) icon on the top right
  11. confirmed it opened https://support.brave.com/hc/en-us/articles/15222663599629-Safe-Browsing-in-Brave in a new tab
Step 4 Step 5 Step 6 Step 9 Step 10 Step 11
Screen Shot 2023-05-16 at 8 40 32 PM Screen Shot 2023-05-16 at 8 40 36 PM Screen Shot 2023-05-16 at 8 43 29 PM Screen Shot 2023-05-16 at 8 40 53 PM Screen Shot 2023-05-16 at 8 40 12 PM Screen Shot 2023-05-16 at 8 40 23 PM

@hffvld
Copy link
Contributor

hffvld commented Jun 9, 2023

Hi @fmarier I just checked Android with Brave Beta and Nightly and see that it transfers user to https://brave.com/privacy/browser/#safe-browsing

Is that expected for Android?

Device/OS: Pixel 7 [panther_beta-user 14 UPB2.230407.019 release-keys]
Brave build: 1.53.83
Chromium: 114.0.5735.110 (Official Build) beta (64-bit)
Revision: 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
timestamp_17-27-47_17-28-08.mp4

@fmarier
Copy link
Member Author

fmarier commented Jun 9, 2023

@vlad-hoff Good catch. It looks like this was accidentally reverted while moving code around in brave/brave-core@b4b7d74

cc @samartnik

@fmarier
Copy link
Member Author

fmarier commented Jun 9, 2023

Android fix in brave/brave-core#18838.

@kjozwiak kjozwiak removed the OS/Android Fixes related to Android browser functionality label Jun 12, 2023
@kjozwiak
Copy link
Member

Android fix in brave/brave-core#18838.

Removing OS/Android from the above issue as Android will be fixed via #30933 in 1.54.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment