-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a learn more link on Safe Browsing setting to our support page #20514
Add a learn more link on Safe Browsing setting to our support page #20514
Comments
Instead of our privacy policy, this should link to https://support.brave.com/hc/en-us/articles/15222663599629-Safe-Browsing-in-Brave. |
Safe Browsing intersitials currently link to the Google support page and so should be updated to point to our page instead. |
Verified
|
Brave | 1.53.45 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64) |
---|---|
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454} |
OS | macOS Version 11.7.6 (Build 20G1231) |
Steps:
- installed
1.53.45
- launched Brave
- waited for 5 minutes
- loaded
https://testsafebrowsing.appspot.com/s/malware.html
- confirmed interstitial page (and clicked
Details
) - confirmed
Learn more
link openedhttps://support.brave.com/hc/en-us/articles/15222663599629-Safe-Browsing-in-Brave
in a new tab - loaded
https://testsafebrowsing.appspot.com/s/malware.html
- clicked on
Back to safety
- confirmed it opened the new-tab page
- opened
brave://settings/security
and clicked on the(?)
icon on the top right - confirmed it opened
https://support.brave.com/hc/en-us/articles/15222663599629-Safe-Browsing-in-Brave
in a new tab
Step 4 |
Step 5 |
Step 6 |
Step 9 |
Step 10 |
Step 11 |
---|---|---|---|---|---|
Hi @fmarier I just checked Android with Brave Beta and Nightly and see that it transfers user to https://brave.com/privacy/browser/#safe-browsing Is that expected for Android?
timestamp_17-27-47_17-28-08.mp4 |
@vlad-hoff Good catch. It looks like this was accidentally reverted while moving code around in brave/brave-core@b4b7d74 cc @samartnik |
Android fix in brave/brave-core#18838. |
Removing |
We now have a section about Safe Browsing in our privacy policy: https://brave.com/privacy/browser/#safe-browsing
We should link to it from
brave://settings/security
on desktop:and from Settings | Brave Shiels & privacy | Safe Browsing on Android:
I don't know whether this needs input from the design team, but for Desktop, I was thinking of a "Learn more" link like this one:
and for Android, perhaps we could simply change what the
(?)
button in the top-right corner links to? Right now, it links to community.brave.com which seems extremely generic and not particularly useful in this context.The text was updated successfully, but these errors were encountered: