Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Greaselion's precondition detection #21021

Open
szilardszaloki opened this issue Feb 10, 2022 · 0 comments
Open

Fix Greaselion's precondition detection #21021

szilardszaloki opened this issue Feb 10, 2022 · 0 comments
Assignees
Labels

Comments

@szilardszaloki
Copy link
Contributor

Description

  1. Greaselion.json should get reparsed on the fly as preconditions defined in it get fulfilled. Currently, it's parsed once, at browser startup. This results in the issue mentioned here.
  2. The precondition of youtubeBase.ts is "rewards-enabled": true, but it even loads with Rewards being turned off:
    2.1. new profile
    2.2. visit youtube.com
    2.3. Greaselion script loaded: youtubeBase.ts appears in developer console
    This results in quite a couple of instances of this:
[3700:9420:0204/140236.445:ERROR:CONSOLE(21770)] "Failed to handle media duration metadata: missing publisher key for media key youtube_3jS_yEK8qVI", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (21770)

Miscellaneous Information:

cc: @Miyayes @brave/rewards-client

@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 16, 2022
@ghost ghost mentioned this issue Sep 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants