Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards Panel always shows 0% attention on twitch #3409

Closed
btlechowski opened this issue Feb 19, 2019 · 10 comments
Closed

Rewards Panel always shows 0% attention on twitch #3409

btlechowski opened this issue Feb 19, 2019 · 10 comments
Assignees

Comments

@btlechowski
Copy link

Follow up from #3329

Steps to Reproduce

  1. Clean profile.
  2. Launch Brave and enable rewards.
  3. Visit some twitch stream so you have some attention % values in auto contribute table.
  4. Show Rewards Panel

Note twitch sites tested:
https://www.twitch.tv/neoness007
https://www.twitch.tv/redpwnie
https://www.twitch.tv/videos/344762635

Actual result:

Rewards Panel show 0%, attention even though a-c table shows >0%
image
image

Expected result:

Rewards Panel shows the same value as a-c table

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

@brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

screen shot 2019-02-20 at 8 54 55 am
screen shot 2019-02-20 at 8 54 46 am

@NejcZdovc
Copy link
Contributor

fixed with #3497

@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Mar 7, 2019
@NejcZdovc NejcZdovc self-assigned this Mar 7, 2019
@btlechowski
Copy link
Author

I am still able to easily reproduce the issue.

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Only difference is that sometimes, the correct Attention is shown, but if I close the Panel and open it again 0 attention is shown.

image

@NejcZdovc would you like me to report another issue or reopen this one?

@NejcZdovc
Copy link
Contributor

@btlechowski so you can't reproduce it like old times, but new STR is to close and open panel again?

@btlechowski
Copy link
Author

@NejcZdovc I can reproduce with the STR from the description, but sometimes when I keep the Panel opened I get a proper attention value. Closing the Panel and Opening it again shows again 0 attention value.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 20, 2019

@btlechowski let's just reopen this one

@NejcZdovc NejcZdovc reopened this Mar 20, 2019
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 20, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 20, 2019

The issue is still Reproducible on

Brave 0.63.15 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

The Panel shows Attention % rate Zero. But, A-C table has Attention greater than Zero

Panel:

image

A-C table:

image

@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 4, 2019
@NejcZdovc NejcZdovc removed this from the 0.63.x - Beta milestone Apr 9, 2019
@NejcZdovc NejcZdovc removed their assignment Sep 3, 2019
@Miyayes
Copy link
Collaborator

Miyayes commented Dec 29, 2021

@btlechowski Is this still an issue with the new Rewards panel?

@btlechowski
Copy link
Author

I was able to reproduce on clean profile, but after restart the Attention is changed after watching a stream. This could be related to #13391.

Brave 1.35.92 Chromium: 97.0.4692.99 (Official Build) beta (64-bit)
Revision d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}}
OS Ubuntu 18.04 LTS

Clean profile:
image

After restart:
image

@szilardszaloki
Copy link
Contributor

The following use case is steadily reproducible:

  1. new profile
  2. enable Rewards
  3. visit a Twitch page (e.g. https://www.twitch.tv/redpwnie) ==> only twitchBase.ts is loaded (twitchAutoContribution.ts is not ==> we can't populate Attention)
  4. restart browser ==> neither twitchBase.ts, nor twitchAutoContribution.ts is loaded (because of a known issue)
  5. refresh page ==> both twitchBase.ts and twitchAutoContribution.ts are loaded (==> populating Attention works fine)

In 3. the precondition of twitchAutoContribution.ts ("auto-contribution-enabled": true) is not fulfilled, because Greaselion.json gets parsed earlier than Rewards gets enabled (at browser startup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants