Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR panel shows Include in Auto-Contribute as enabled when a-c is disabled globally #3103

Closed
srirambv opened this issue Jan 25, 2019 · 2 comments · Fixed by brave/brave-core#1525
Assignees
Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

BR panel shows Include in Auto-Contribute as enabled when a-c is disabled globally

Steps to Reproduce

  1. Enable rewards
  2. Disable a-c in brave://rewards
  3. Visit any site and open BR panel , Include in Auto-Contribute is enabled even though a-c is disabled in rewards settings page

Actual result:

BR panel shows Include in Auto-Contribute as enabled when a-c is disabled globally

Expected result:

BR panel should probably hide the Attention and Include in Auto-contribute lines when a-c is disabled.

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Additional Information

cc: @davidtemkin @jenn-rhim @NejcZdovc
Issue reported by community user https://community.brave.com/t/bug-alert-i-turned-off-the-automatic-rewards-but-it-turns-itself-on-for-any-new-website-visited/43082/7

@srirambv srirambv added suggestion design A design change, especially one which needs input from the design team feature/rewards QA/Yes release-notes/exclude labels Jan 25, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 25, 2019
@NejcZdovc
Copy link
Contributor

Agree

@btlechowski
Copy link

btlechowski commented Feb 25, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1525

a-c off
image

a-c on
image

Verification passed on

Brave 0.61.39 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux Mint

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants