Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bat_get_media in native ledger #4005

Closed
NejcZdovc opened this issue Apr 4, 2019 · 1 comment · Fixed by brave/brave-core#2167
Closed

Simplify bat_get_media in native ledger #4005

NejcZdovc opened this issue Apr 4, 2019 · 1 comment · Fixed by brave/brave-core#2167

Comments

@NejcZdovc
Copy link
Contributor

Current bat_get_media.cc is really all around and it's hard to add any new platform. Because of this we need to simplify it. This file will now only contain shared functionalities and every platform will have their own file with their own functionalities

@LaurenWags
Copy link
Member

LaurenWags commented May 21, 2019

Verified passed with

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from Simplify media structure inside native ledger  brave-core#2167
  • Verified additional media related items such as: if the setting for 'Allow Contribution to Videos' is off, no videos were added to ac table. Verified able to tip verified YT and Twitch pubs when AC is off and the expected favicons display in both the Tips list and the Rewards Panel.

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux
  • Verified test plan from Simplify media structure inside native ledger  brave-core#2167
  • Verified additional media related items such as: if the setting for 'Allow Contribution to Videos' is off, no videos were added to ac table. Verified able to tip verified YT and Twitch pubs when AC is off and the expected favicons display in both the Tips list and the Rewards Panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants