Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify media structure inside native ledger #2167

Merged
merged 12 commits into from
Apr 18, 2019
Merged

Simplify media structure inside native ledger #2167

merged 12 commits into from
Apr 18, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 5, 2019

Resolves brave/brave-browser#4005

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Main thing to test in this PR is if youtube/twitch are working correctly. Twitch has known problems with regards to the panel brave/brave-browser#3590 and brave/brave-browser#3417. In this PR no logic was changed, we just moved code into separate files to simplify code flow.

Things to test:

  • media publisher (YT or Twitch) is added to AC table after watching a video
  • going to a video you can see media publisher in the panel
  • you can tip a media publisher
  • for verified media publisher you should see their image in the panel and AC table

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Apr 5, 2019
@NejcZdovc NejcZdovc changed the title Base ground for the split Simplify media structure inside native ledger Apr 5, 2019
@NejcZdovc NejcZdovc force-pushed the media-split branch 7 times, most recently from ff88164 to 2ea50eb Compare April 15, 2019 09:10
@jasonrsadler jasonrsadler force-pushed the media-split branch 2 times, most recently from 5c5bee5 to 3ce814a Compare April 15, 2019 11:19
@NejcZdovc NejcZdovc force-pushed the media-split branch 4 times, most recently from a15adf5 to deeb65a Compare April 16, 2019 17:50
@NejcZdovc NejcZdovc marked this pull request as ready for review April 17, 2019 09:58
@NejcZdovc NejcZdovc requested review from bridiver, jasonrsadler and ryanml and removed request for bridiver April 17, 2019 09:58
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorganization looks good, test plan worked fine. Twitch panel issue was noted (Consistently saw twitch.com in the panel, but publishers filled the AC table with the expected name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify bat_get_media in native ledger
2 participants