Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running unit tests in release mode fails when not official build #4342

Closed
bsclifton opened this issue May 8, 2019 · 0 comments · Fixed by brave/brave-core#2385
Closed

Running unit tests in release mode fails when not official build #4342

bsclifton opened this issue May 8, 2019 · 0 comments · Fixed by brave/brave-core#2385
Assignees
@bsclifton
Labels
QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
0.65.x - Release ...

Comments

@bsclifton
Copy link
Member

Description

When building from source, specifically a release build with official_build=false, there are two test failures:

2 tests failed:
    MediaYouTubeTest.GetChannelUrl (../../brave/vendor/bat-native-ledger/src/bat/ledger/internal/media/youtube_unittest.cc:498)
    MediaYouTubeTest.GetVideoUrl (../../brave/vendor/bat-native-ledger/src/bat/ledger/internal/media/youtube_unittest.cc:466)

Problem introduced in brave/brave-core#2167, meaning it occurs in master/0.66.x/0.65.x

Steps to Reproduce

  1. Clone brave-browser
  2. npm run init -- --all && npm run build -- Release --official_build=false
  3. npm test brave_unit_tests -- Release

Actual result:

Errors

Expected result:

Tests should pass
@bsclifton bsclifton added this to the 0.67.x - Nightly milestone May 8, 2019
@bsclifton bsclifton self-assigned this May 8, 2019
bsclifton added a commit to brave/brave-core that referenced this issue May 8, 2019
@bsclifton
Update test to use NDEBUG check instead of only the OFFICIAL_BUILD
6598599 
Fixes brave/brave-browser#4342

(release tests were failing with official build = false)
@bsclifton bsclifton mentioned this issue May 8, 2019
Merged
28 tasks
@jonathanKingston jonathanKingston mentioned this issue Feb 11, 2020
Merged
32 tasks
jonathanKingston added a commit to jonathanKingston/brave-core that referenced this issue Feb 11, 2020
@jonathanKingston
Fix youtube unittest in debug build.
1503efd 
Fixes: brave/brave-browser#4342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update test to use NDEBUG check instead of only the OFFICIAL_BUILD brave/brave-core
1 participant
@bsclifton