Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to use NDEBUG check instead of only the OFFICIAL_BUILD #2385

Merged
merged 1 commit into from
May 8, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 8, 2019

Fixes brave/brave-browser#4342

(release tests were failing with official build = false)

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes brave/brave-browser#4342

(release tests were failing with official build = false)
@bsclifton bsclifton added this to the 0.67.x - Nightly milestone May 8, 2019
@bsclifton bsclifton self-assigned this May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running unit tests in release mode fails when not official build
2 participants