Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix youtube unittest in debug build. #4590

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Feb 11, 2020

Resolves: brave/brave-browser#7752

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc merged commit 1618cea into brave:master Feb 13, 2020
@NejcZdovc
Copy link
Contributor

@jonathanKingston thank you very much for the fix 🎉

@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unit tests on debug build
3 participants