Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitch.tv instead of publisher name is shown on Brave Panel #3417

Closed
btlechowski opened this issue Feb 19, 2019 · 2 comments · Fixed by brave/brave-core#2618
Closed

twitch.tv instead of publisher name is shown on Brave Panel #3417

btlechowski opened this issue Feb 19, 2019 · 2 comments · Fixed by brave/brave-core#2618

Comments

@btlechowski
Copy link

btlechowski commented Feb 19, 2019

Follow up from #3043

Steps to Reproduce

  1. Clean install
  2. Enable rewards
  3. Open a twitch stream
  4. Reload
  5. Immediately open Rewards Panel

Actual result:

twitch.tv is shown on Brave Panel
twitch_panel

Note: After closing the Panel and opening it again. Publisher name is shown.

Expected result:

publisher is shown on Brave Panel

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

cc @brave/legacy_qa @jasonrsadler @NejcZdovc

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

@btlechowski
Copy link
Author

btlechowski commented Jun 14, 2019

Good work @NejcZdovc

Verification passed on

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Windows 7 Service Pack 1 (Build 7601.24468)

Verified the testplan from the description and brave/brave-core#2618

Verified passed with

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Mac OS X

Verification passed on

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Ubuntu 18.04 LTS

Verified the testplan from the description and brave/brave-core#2618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment