-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fixes twitch panel #1887
WIP: Fixes twitch panel #1887
Conversation
4df73d7
to
6d26a00
Compare
vendor/bat-native-ledger/src/bat/ledger/internal/bat_get_media.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Enable Rewards
- Go to twitch VOD
- Play video and open panel and let publisher display
- Refresh page and quickly open panel and leave open.
The publisher will display while the reload is in progress. When the user's icon loads on the page, the panel switches to 'twitch.tv'
@jasonrsadler can you please re-test this one. I can't reproduce quick open problem. If the problem is only for quick opens, let's merge this one and create new issue for it. Thank you |
for quick open we can create new issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3ead9d4
to
27e139c
Compare
stale |
Resolves brave/brave-browser#3590
Resolves brave/brave-browser#3417
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: