Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixes twitch panel #1887

Closed
wants to merge 3 commits into from
Closed

WIP: Fixes twitch panel #1887

wants to merge 3 commits into from

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 7, 2019

Resolves brave/brave-browser#3590
Resolves brave/brave-browser#3417

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Enable Rewards
  • Visit a twitch streamer (twitch.tv/jenoki works if you want a verified one)
  • Even if user is streaming, play a VOD.
  • After the video has been playing for a few seconds, open the panel.
  • Make sure that you see publisher in the panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Mar 7, 2019
@NejcZdovc NejcZdovc self-assigned this Mar 7, 2019
@NejcZdovc NejcZdovc force-pushed the twitch-vod branch 3 times, most recently from 4df73d7 to 6d26a00 Compare March 7, 2019 06:45
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Enable Rewards
  2. Go to twitch VOD
  3. Play video and open panel and let publisher display
  4. Refresh page and quickly open panel and leave open.

The publisher will display while the reload is in progress. When the user's icon loads on the page, the panel switches to 'twitch.tv'

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Mar 25, 2019

@jasonrsadler can you please re-test this one. I can't reproduce quick open problem. If the problem is only for quick opens, let's merge this one and create new issue for it. Thank you

@NejcZdovc NejcZdovc dismissed jasonrsadler’s stale review March 25, 2019 06:37

for quick open we can create new issue

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong publisher is getting shown. STR:

  1. Enable Rewards. Go to Twitch
  2. View a publisher VOD. Open panel to see publisher.
  3. Go to a different live streamer, and before clicking panel, click on videos to go to video list.
  4. Click on panel.
    Observe previous publisher from VOD is shown.

Screen Shot 2019-03-25 at 10 51 30 AM

@NejcZdovc NejcZdovc force-pushed the twitch-vod branch 2 times, most recently from 3ead9d4 to 27e139c Compare March 27, 2019 10:13
@NejcZdovc NejcZdovc changed the title Fixes twitch panel WIP: Fixes twitch panel Mar 28, 2019
@NejcZdovc NejcZdovc removed this from the 0.65.x - Dev milestone Apr 19, 2019
@NejcZdovc NejcZdovc removed the request for review from ryanml June 6, 2019 09:09
@NejcZdovc
Copy link
Contributor Author

stale

@NejcZdovc NejcZdovc closed this Jun 6, 2019
@NejcZdovc NejcZdovc deleted the twitch-vod branch June 6, 2019 09:09
@NejcZdovc NejcZdovc added this to the Closed milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panel not showing twitch publisher info for VOD twitch.tv instead of publisher name is shown on Brave Panel
2 participants