Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect Twitch link in auto contribute and tips tables #4921

Closed
LaurenWags opened this issue Jun 14, 2019 · 9 comments · Fixed by brave/brave-core#2725
Closed

incorrect Twitch link in auto contribute and tips tables #4921

LaurenWags opened this issue Jun 14, 2019 · 9 comments · Fixed by brave/brave-core#2725

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jun 14, 2019

Description

When visiting a twitch page (ex. twitch.tv/psherotv), the channel is correctly added to the AC table, however the link for the channel is incorrect. The link should be https://www.twitch.tv/psherotv/videos however it is actually https://www.twitch.tv/psherotv/videos/videos. If you continue to revisit the page (either in a new tab or refresh the existing tab) another /videos will be appended to the link, so it's pretty easy to end up with a link like https://www.twitch.tv/psherotv/videos/videos/videos/videos/videos.

This is occurring on release channel version 0.65.120 but not on 0.65.118 (currently released version).

Steps to Reproduce

  1. Install 0.65.120 and enable Rewards.
  2. Visit a twitch channel such as https://www.twitch.tv/psherotv (I think this has to do with live streams, but should check VODs as well)
  3. Wait for channel to be added to AC table.
  4. On https://www.twitch.tv/psherotv/ refresh the page a couple of times.

Actual result:

View your AC table and hover over the entry for psherotv:
Screen Shot 2019-06-14 at 11 14 44 AM

Expected result:

Link should not change when you refresh or revisit the page.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? 0.65.120 yes, but 0.65.118 no
  • Can you reproduce this issue with the beta channel? 0.66.88 no
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Reproduced on macOS and Win by @kjozwiak

@LaurenWags
Copy link
Member Author

Issue did not reproduce with 0.66.88 on Beta:

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X

@LaurenWags
Copy link
Member Author

Looks like twitch doesn't redirect https://www.twitch.tv/psherotv/videos/videos, but will redirect something like https://www.twitch.tv/psherotv/videos/videos/videos/videos/videos/videos.

Link is still wrong, but it seems to have less of an impact.

@LaurenWags LaurenWags changed the title incorrect Twitch link in auto contribute table incorrect Twitch link in auto contribute and tips tables Jun 14, 2019
@LaurenWags
Copy link
Member Author

Same issue occurs in Tips table:
Screen Shot 2019-06-14 at 11 59 21 AM

@btlechowski
Copy link

Reproduced on Windows

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Windows 7 Service Pack 1 (Build 7601.24468)

@btlechowski
Copy link

It seems that publisher_info_db becomes corrupted with the wrong url.
image

NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 18, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 18, 2019
@NejcZdovc NejcZdovc self-assigned this Jun 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 25, 2019
@LaurenWags
Copy link
Member Author

Additional way to reproduce:
Watch a livestream. As the attention % on your AC table increases, another /videos will be added to the URL.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 25, 2019

The issue is Reproducible on.

Brave 0.66.97 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

Publishers_Info:
image

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya this problem is on release (0.65) and all version except 68 where fix already landed

@NejcZdovc NejcZdovc removed this from the 0.68.x - Dev milestone Jun 25, 2019
@srirambv
Copy link
Contributor

srirambv commented Jun 28, 2019

Verification passed on

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

Verification passed on

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified twitch link doesn't add extra /videos at the end of the link
    image

  • Verified db isn't corrupted with extra /videos

image

Verified passed with

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Screen Shot 2019-06-28 at 3 34 08 PM

Screen Shot 2019-06-28 at 3 36 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment