Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet icon needs to more lighter similar to Talk and Bookmarks #21172

Closed
srirambv opened this issue Feb 17, 2022 · 3 comments · Fixed by brave/brave-core#12334
Closed

Wallet icon needs to more lighter similar to Talk and Bookmarks #21172

srirambv opened this issue Feb 17, 2022 · 3 comments · Fixed by brave/brave-core#12334

Comments

@srirambv
Copy link
Contributor

Description

Wallet icon needs to more lighter similar to Talk and Bookmarks

Steps to Reproduce

  1. Install nightly build
  2. Set browser to dark theme
  3. Wallet is barely visible but on hover shows the correct hover state

Actual result:

No Hover On hover
image image

Expected result:

Should be same as the other two default buttons

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.53 Chromium: 98.0.4758.102 (Official Build) nightly (arm64)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS macOS Version 12.1 (Build 21C52)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @rebron @simonhong

@simonhong
Copy link
Member

This is duplicated issue - #21100

@simonhong simonhong self-assigned this Feb 18, 2022
simonhong added a commit to brave/brave-core that referenced this issue Feb 18, 2022
fix brave/brave-browser#21172

When theme is changed wallet item is not handled.
Also add button had same issue and fixed together.
@simonhong
Copy link
Member

Wallet icon was not updated when theme changed during the runtime.
New window after changing theme has proper wallet icon color.

@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 18, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 2, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Mar 8, 2022

Brave 1.37.84 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified wallet icon is clearly visible on both dark and light mode
Light theme
21172-Linux.Light.mp4
21172-Windows.Light.mov
21172-macOS.Light.mov
Dark theme
21172-Linux.Dark.mp4
21172-Windows.Dark.mov
21172-macOS.Dark.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants