Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When wallet is not yet created and user tries to reset the wallet, the wallet reset process should not continue #21274

Closed
GeetaSarvadnya opened this issue Feb 23, 2022 · 3 comments
Assignees

Comments

@GeetaSarvadnya
Copy link

Description

When wallet is not yet created and user tries to reset the wallet, the wallet reset process should not continue

Steps to Reproduce

  1. Clean profile 1.35.x or 1.37.x
  2. Open brave://rewards
  3. Tap on Manage Your wallet
  4. Click on Reset
  5. Message is shown as Are you sure you want to reset your Rewards Wallet?
  6. This message needs to be rephrased, when the user tries to reset the wallet when the wallet is not created, the user should get a message as the wallet is not yet created and it should not continue the reset process

Actual result:

When wallet is not yet created and the user tries to reset the wallet, the wallet reset process should not continue
image

Expected result:

When wallet is not yet created and user tries to reset the wallet, the wallet reset process should not continue

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.68 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1526)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @Miyayes @LaurenWags

@LaurenWags
Copy link
Member

@Miyayes should the whole "Manage your wallet" area even be shown if you haven't opted into Rewards yet?

@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Jun 29, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jun 29, 2022

It makes the most sense if we just not show the Manage Your Wallet button.

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 20, 2023

No longer valid.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@kjozwiak kjozwiak added closed/invalid and removed suggestion feature/rewards priority/P4 Planned work. We expect to get to it "soon". OS/Desktop labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants