Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all version related file when builds #579

Closed
simonhong opened this issue Jul 18, 2018 · 2 comments
Closed

Check all version related file when builds #579

simonhong opened this issue Jul 18, 2018 · 2 comments
Labels
closed/no-milestone

Comments

@simonhong
Copy link
Member

simonhong commented Jul 18, 2018 •
edited
Loading

brave-browser/package.json, chrome/VERSION and brave-core/package.json
All these files must use same brave version.

If they have different value, unexpected behavior will be happened. (ex, install)

I think using more than one file is error prone.
This was referenced Jul 18, 2018
Merged
Merged
@bbondy
Copy link
Member

bbondy commented Jul 26, 2018

We're going to stop using brave-core/package.json and just keep it at 0.0.1

@bbondy bbondy added this to the Backlog milestone Jul 26, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@btlechowski btlechowski mentioned this issue Feb 17, 2022
Closed
33 tasks
@stephendonner stephendonner mentioned this issue Feb 18, 2022
Closed
This was referenced Feb 22, 2022
Closed
Closed
This was referenced Feb 22, 2022
Closed
Closed
Closed
Closed
Closed
@stephendonner stephendonner mentioned this issue Feb 23, 2022
Closed
This was referenced Feb 23, 2022
Closed
Closed
Closed
Open
Closed
This was referenced Feb 23, 2022
Closed
Closed
@bsclifton
Copy link
Member

We should be good to go on this now 😄 Checks in place and most logic moved to brave-core

@Kingcrypto38 Kingcrypto38 mentioned this issue Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/no-milestone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @bsclifton @rebron @simonhong