Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsing data list is empty in On Exit tab in brave://settings/clearBrowserData #21225

Closed
GeetaSarvadnya opened this issue Feb 22, 2022 · 1 comment · Fixed by brave/brave-core#12358

Comments

@GeetaSarvadnya
Copy link

Description

Browsing data list is empty in On Exit tab in brave://settings/clearBrowserData

Steps to Reproduce

  1. Open 1.37.x
  2. Navigate to brave://settings/clearBrowserData
  3. Tap on On Exit tab
  4. Browsing data list is empty in On Exit tab

Actual result:

Browsing data list is empty in On Exit tab in brave://settings/clearBrowserData

image

Expected result:

Browsing data list should not be empty in On Exit tab

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.61 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1526)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @mkarolin

mkarolin pushed a commit to brave/brave-core that referenced this issue Feb 22, 2022
…sChild API

Fixes brave/brave-browser#21225

Needed to rename isSupervised to isChildAccount to match upstream. Bug
manifested itself as missing settings for "Clear on Exit" and an error in the
JavaScript console.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/5441f9b71eecac1b8acfafa78dbc7c4148cb2143

commit 5441f9b71eecac1b8acfafa78dbc7c4148cb2143
Author: Nohemi Fernandez <fernandex@chromium.org>
Date:   Tue Dec 14 13:11:35 2021 +0000

    Update WebUI JS code naming to reflect the Profile::IsChild API.

    Follow-up to crrev.com/c/3314914.

    Bug: 1277015
@mkarolin mkarolin self-assigned this Feb 22, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 22, 2022
@mkarolin mkarolin added this to the 1.37.x - Nightly milestone Feb 22, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.36.105 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}

Steps:

  1. installed 1.36.105
  2. launched Brave
  3. opened brave://settings/clearBrowserData
  4. clicked on the On exit tab pane

Confirmed the On exit pane was populated both with data - both the category types and accrued.

light dark
21225-1 21225-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment