Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar item add bubble is anchored at wrong place #21151

Closed
simonhong opened this issue Feb 17, 2022 · 1 comment · Fixed by brave/brave-core#12308
Closed

Sidebar item add bubble is anchored at wrong place #21151

simonhong opened this issue Feb 17, 2022 · 1 comment · Fixed by brave/brave-core#12308

Comments

@simonhong
Copy link
Member

When browser window doesn't have enough space to show item add bubble anchor position is changed implicitely.
Due to this bubble is shown like below.
Screenshot 2022-02-17 094318

Bubble should be anchored to add button like below.
Screenshot 2022-02-17 094452

STR:

  1. Launch browser and reduce browser window
  2. Hover mouce over add item button
@simonhong simonhong self-assigned this Feb 17, 2022
simonhong added a commit to brave/brave-core that referenced this issue Feb 17, 2022
fix brave/brave-browser#21151

bubble border should handle for bottm left positioned anchor.
simonhong added a commit to brave/brave-core that referenced this issue Feb 22, 2022
fix brave/brave-browser#21151

bubble border should handle for bottm left positioned anchor.
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 22, 2022
bsclifton pushed a commit to brave/brave-core that referenced this issue Feb 22, 2022
fix brave/brave-browser#21151

bubble border should handle for bottm left positioned anchor.
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 22, 2022
@stephendonner
Copy link

stephendonner commented Feb 23, 2022

Verified PASSED using

Brave 1.37.68 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 11 Version 21H2 (Build 22000.527)

Followed the steps above and resized the window at various dimensions; confirmed the Add to Sidebar flyout was aligned with the + at each time.

example example example
21151-1 21151-2 21151-3

Verified PASSED using

Brave 1.37.84 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.3 (Build 20G415)

Followed the steps above and resized the window at various dimensions; confirmed the Add to Sidebar flyout was aligned with the + at each time.

example example example
Screen Shot 2022-03-09 at 3 56 54 PM Screen Shot 2022-03-09 at 3 57 27 PM Screen Shot 2022-03-09 at 3 57 08 PM

Verification passed on

Brave 1.37.95 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Ubuntu 18.04 LTS

Verified test plan from the description

confirmed the Add to Sidebar flyout was aligned with the +.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants