Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar items re-ordering is broken #21213

Closed
simonhong opened this issue Feb 21, 2022 · 1 comment · Fixed by brave/brave-core#12345
Closed

Sidebar items re-ordering is broken #21213

simonhong opened this issue Feb 21, 2022 · 1 comment · Fixed by brave/brave-core#12345
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop OS/Linux OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.37.x - Release

Comments

@simonhong
Copy link
Member

Sidebar items re-ordering is broken with latest master build.
After droping to new position, item should be moved to new position.
However, item's position is not changed and re-ordering status bar is also not cleared like below.
image

This is not reproducible on latest nightly build 1.37.56. I assume this regression comes from C99 rebase.
Note: This doesn't happen on macOS.
@simonhong simonhong self-assigned this Feb 21, 2022
@simonhong simonhong added regression and removed bug labels Feb 21, 2022
@simonhong simonhong mentioned this issue Feb 21, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 21, 2022
@simonhong
Fixed sidebar items reordering
b3094aa 
fix brave/brave-browser#21213

On Windows/Linux, drag and drop was switched to work with GetDropCallback
instead of OnPerformDrop.
Currently, OpPerformDrop is only used on macOS.
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 22, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 22, 2022
@stephendonner
Copy link

stephendonner commented Feb 22, 2022 •
edited by btlechowski
Loading

Verified PASSED using

Brave 1.37.65 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1566)

Steps:

  1. new profile
  2. launched Brave
  3. clicked on, dragged, and reordered the Sidebar icons dynamically

drag-and-drop-sidebar

Verification passed on

Brave 1.37.86 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

21213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop OS/Linux OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed sidebar items reordering brave/brave-core
5 participants
@stephendonner @rebron @simonhong @LaurenWags @btlechowski