Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minor version #268

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Bump minor version #268

merged 2 commits into from
Jul 18, 2018

Conversation

RyanJarv
Copy link
Contributor

Updating to match brave/brave-browser/pull/587

@RyanJarv RyanJarv requested a review from mbacchi July 18, 2018 17:26
Bad things happen if this doesn't match brave/brave-browser#587 and the package.json for this repo.
@RyanJarv
Copy link
Contributor Author

RyanJarv commented Jul 18, 2018

The chromium version patch thing is new. If we forget that and don't catch it before release we will get stuck on the chromium versioning scheme.

Ticket open for this here: brave/brave-browser#579

Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@RyanJarv RyanJarv merged commit 3d5c2a6 into master Jul 18, 2018
@RyanJarv RyanJarv deleted the RyanJarv-patch-1 branch July 19, 2018 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants