Bump patch version #587
Merged
Bump patch version #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping 12 because it was used for some ad-hoc testing, also 13 == good luck
RyanJarv
requested review from
cezaraugusto,
mbacchi and
bbondy
and removed request for
cezaraugusto
|
@bbondy this will likely be the one we use for the unofficial dev rerelease. Let me know if you have any thoughts here. |
mbacchi
approved these changes
Jul 18, 2018
RyanJarv
added a commit
to brave/brave-core
that referenced
this pull request
Jul 18, 2018
Updating to match brave/brave-browser/pull/587
RyanJarv
added a commit
to brave/brave-core
that referenced
this pull request
Jul 18, 2018
Bad things happen if this doesn't match brave/brave-browser#587 and the package.json for this repo.
|
FYI we have one other place we need to update versions in now as well :/ https://github.com/brave/brave-core/pull/268/files#diff-6faf6f9a67e6c736e3a64ad100c7dcdc If we forget that and don't catch it before release we will get stuck on the chromium versioning scheme. Ticket open for this here: #579 |
RyanJarv
added a commit
to brave/brave-core
that referenced
this pull request
Jul 18, 2018
* Bump minor version Updating to match brave/brave-browser/pull/587 * Bump patch version Bad things happen if this doesn't match brave/brave-browser#587 and the package.json for this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping 12 because it was used for some ad-hoc testing, also 13 == good luck