Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for keyboard input / middle click when processing click on sidebar shortcuts #21157

Closed
bsclifton opened this issue Feb 17, 2022 · 2 comments · Fixed by brave/brave-core#12330
Closed

Check for keyboard input / middle click when processing click on sidebar shortcuts #21157

bsclifton opened this issue Feb 17, 2022 · 2 comments · Fixed by brave/brave-core#12330
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature feature-request OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@bsclifton
Copy link
Member

Description

Sidebar is a great new feature on Nightly. It has a feature where you can click the + icon to add the site you're currently viewing as a shortcut to the sidebar

It would be great if this used similar logic to following links inside a web page (or similar to the bookmarks manager inside the sidebar). Basically Ctrl + Click opening in a new tab, middle click the link to open in a new tab, etc.
@bsclifton bsclifton added feature-request OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Feb 17, 2022
@simonhong simonhong self-assigned this Feb 18, 2022
@simonhong
Copy link
Member

Bookmarks bar behavior. Sidebar shortcut item should have same behavior.
Ctrl + click, middle click - opens in new background tab
Shift + click - opens in new window.

simonhong added a commit to brave/brave-core that referenced this issue Feb 18, 2022
@simonhong
Makes sidebar item handles window disposition event
3ed3f80 
fix brave/brave-browser#21157

Same with bookmarks button behavior.
* Ctrl + click, middle click - opens in new background tab
* Shift + click - opens in new window.
@simonhong simonhong mentioned this issue Feb 18, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 18, 2022
@simonhong
Makes sidebar item handles window disposition event
af97a92 
fix brave/brave-browser#21157

Same with bookmarks button behavior.
* Ctrl + click, middle click - opens in new background tab
* Shift + click - opens in new window.
bsclifton pushed a commit to brave/brave-core that referenced this issue Feb 22, 2022
@simonhong @bsclifton
Makes sidebar item handles window disposition event
e0118b6 
fix brave/brave-browser#21157

Same with bookmarks button behavior.
* Ctrl + click, middle click - opens in new background tab
* Shift + click - opens in new window.
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 22, 2022
@stephendonner
Copy link

stephendonner commented Feb 23, 2022 •
edited by btlechowski
Loading

Verified PASSED using

Brave 1.37.65 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1566)

Steps:

  1. install 1.37.65
  2. launched Brave
  3. loaded brave.com
  4. hovered over the + icon in Sidebar
  5. choose Add to Sidebar - brave.com from the popup
  6. left-clicked on the Brave favicon in Sidebar
  7. ctrl-clicked/middle-clicked on the Brave favicon in Sidebar
  8. shift-clicked on the Brave favicon in Sidebar

Confirmed:
6. opened brave.com in the current tab
7. opened brave.com in a new tab
8. opened brave.com in a new window

step 5 step 6 step 7 step 8
21157-1 21157-2 21157-4 21157-3

Verified PASSED using

Brave 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 12.3 (Build 21E230)

Steps:

  1. install 1.37.91
  2. launched Brave
  3. loaded brave.com
  4. hovered over the + icon in Sidebar
  5. choose Add to Sidebar - brave.com from the popup
  6. left-clicked on the Brave favicon in Sidebar
  7. ctrl-clicked/middle-clicked on the Brave favicon in Sidebar
  8. shift-clicked on the Brave favicon in Sidebar

Confirmed:
6. opened brave.com in the current tab
7. opened brave.com in a new tab
8. opened brave.com in a new window

step 5 step 6 step 7 step 8
Screen Shot 2022-03-14 at 5 37 47 PM Screen Shot 2022-03-14 at 5 41 46 PM Screen Shot 2022-03-14 at 5 38 03 PM Screen Shot 2022-03-14 at 5 38 16 PM

Verification passed on

Brave 1.37.95 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Ubuntu 18.04 LTS

Verified test plan from the descritpion

Left Click

image

Control + Left Click

image

Shift + Left Click

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature feature-request OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Makes sidebar item handles window disposition event brave/brave-core
5 participants
@stephendonner @bsclifton @simonhong @LaurenWags @btlechowski