Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising txn confirmation screen based on the txn type #21758

Closed
onyb opened this issue Mar 18, 2022 · 1 comment
Closed

Allow customising txn confirmation screen based on the txn type #21758

onyb opened this issue Mar 18, 2022 · 1 comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@onyb
Copy link
Member

onyb commented Mar 18, 2022

Currently, the ConfirmTransactionPanel is crammed with custom logic for all the different transaction types. The idea is to have dedicated components for each txn type. A good candidate for this is the confirmation screen for swap. The goal of this issue is to refactor ConfirmTransactionPanel to allow rendering a component dedicated to swap when interacting with the 0x Exchange Proxy

Here's an example from Metamask:

Some UX customisation ideas (outside the scope of this issue):

  • No need to display the Total.
  • Indicate the make and taker assets, along with their quoted amounts.
  • Display exchange rate.
  • Approve + Swap in batch.
  • Fetch the full swap quote in the confirmation screen every 40s, so quote details including order route and liquidity sources are available to be displayed.
@onyb onyb added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Mar 18, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 27, 2022
@onyb
Copy link
Member Author

onyb commented Sep 13, 2022

Closed in brave/brave-core#14745.

@onyb onyb closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Archived in project
Development

No branches or pull requests

2 participants