Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): add transaction review screen for ETHSwap #14745

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Aug 22, 2022

Resolves brave/brave-browser#24860

Slight design variations from the Figma spec were done after internal discussions with product/design.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo:

Screen.Recording.2022-08-23.at.02.16.57.mov

Test plan

Create a swap transaction for the following cases, and it should accurately display the maker/taker assets and amounts involved in the swap as seen in the demo above:

Networks: (mainnet only)

  • Ethereum
  • Polygon
  • BSC
  • Optimism
  • Celo (not verified)
  • Fantom (not verified)
  • Avalanche (not verified)

Pairs:

  • ETH -> ERC20
  • ERC20 -> ETH
  • ERC20 -> ERC20

Verify in the screenshot that the correct asset logos and the corresponding network are appropriately displayed.

@onyb onyb self-assigned this Aug 22, 2022
@onyb onyb requested a review from a team as a code owner August 22, 2022 20:57
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 22, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb force-pushed the f/wallet/swap-review-screen branch from 80cba34 to 1a1330d Compare August 23, 2022 09:28
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dedicated transaction review screen for ETHSwap
3 participants