-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): add transaction review screen for ETHSwap #14745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
Deploy storybook and provide a unique URL for each build
label
Aug 22, 2022
A Storybook has been deployed to preview UI for the latest push |
onyb
force-pushed
the
f/wallet/swap-review-screen
branch
from
August 23, 2022 09:28
80cba34
to
1a1330d
Compare
A Storybook has been deployed to preview UI for the latest push |
Douglashdaniel
requested changes
Aug 23, 2022
components/brave_wallet_ui/components/extension/confirm-transaction-panel/common/footer.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/common/gas.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/common/origin.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/common/queue.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/common/style.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/swap.stories.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/swap.style.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/swap.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/swap.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/confirm-transaction-panel/swap.tsx
Outdated
Show resolved
Hide resolved
onyb
force-pushed
the
f/wallet/swap-review-screen
branch
from
August 23, 2022 16:01
1a1330d
to
d8b3a5c
Compare
Douglashdaniel
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#24860
Slight design variations from the Figma spec were done after internal discussions with product/design.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Demo:
Screen.Recording.2022-08-23.at.02.16.57.mov
Test plan
Create a swap transaction for the following cases, and it should accurately display the maker/taker assets and amounts involved in the swap as seen in the demo above:
Networks: (mainnet only)
Pairs:
ETH -> ERC20
ERC20 -> ETH
ERC20 -> ERC20
Verify in the screenshot that the correct asset logos and the corresponding network are appropriately displayed.