Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated transaction review screen for ETHSwap #24860

Closed
onyb opened this issue Aug 22, 2022 · 1 comment · Fixed by brave/brave-core#14745
Closed

Add dedicated transaction review screen for ETHSwap #24860

onyb opened this issue Aug 22, 2022 · 1 comment · Fixed by brave/brave-core#14745
Assignees
@onyb
Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@onyb
Copy link
Member

onyb commented Aug 22, 2022

We're now able to parse 0x Swap transactions into an ETHSwap type. Implement a dedicated swap review screen to display this information.

Figma https://www.figma.com/file/jZrVG7dsi5npXFTDC6LDGn/Crypto?node-id=4520%3A138295
@onyb onyb added QA/Yes release-notes/include OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/swap labels Aug 22, 2022
@onyb onyb self-assigned this Aug 22, 2022
@onyb onyb mentioned this issue Aug 22, 2022
Merged
25 tasks
@onyb onyb added this to the 1.45.x - Nightly milestone Aug 24, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 28, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Linux
  • Verified test plan from brave/brave-core#14745
  • Verified transaction review screen is as per spec and shows the correct network/token icons
24860.mp4

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified test plan from brave/brave-core#14745
  • Verified transaction review screen is as per spec and shows the correct network/token icons
24860.mp4

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (arm64)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS macOS Version 12.4 (Build 21F79)
  • Verified test plan from brave/brave-core#14745
  • Verified transaction review screen is as per spec and shows the correct network/token icons
24860.mov

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): add transaction review screen for ETHSwap brave/brave-core
3 participants
@onyb @srirambv @LaurenWags