Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser crash when selecting 'Send to your devices' #22128

Closed
samartnik opened this issue Apr 6, 2022 · 11 comments · Fixed by brave/brave-core#12920
Closed

Browser crash when selecting 'Send to your devices' #22128

samartnik opened this issue Apr 6, 2022 · 11 comments · Fixed by brave/brave-core#12920
Assignees
@samartnik
Labels
bug crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include
Milestone
1.37.x - Release #6

Comments

@samartnik
Copy link
Contributor

samartnik commented Apr 6, 2022 •
edited by kjozwiak
Loading

Description

Brave crashes when clicking on send to device in Android.

Steps to reproduce

Prerequisite: ensure that syncing is enabled and Open Tabs is selected on both the Desktop & Android devices.

  1. Open the menu
  2. Click on share
  3. Select 'send to your devices'

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@samartnik samartnik added priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality labels Apr 6, 2022
@samartnik samartnik self-assigned this Apr 6, 2022
@samartnik samartnik mentioned this issue Apr 6, 2022
Merged
25 tasks
This was referenced Apr 6, 2022
Merged
Merged
@kjozwiak kjozwiak added this to the 1.37.x - Release #5 milestone Apr 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2022

Above will require 1.37.113 or newer for 1.37.x verification.

@samartnik samartnik mentioned this issue Apr 8, 2022
Closed
@marc0der
Copy link

Hi @samartnik, thanks for being all over this! Just out of curiosity, when will this fix be released?

@steveharman
Copy link

I'm still getting this on Android with 1.37.112 - is that expected?

@samartnik
Copy link
Contributor Author

@marc0der I believe new update with the fix should be out sometime this week
@steveharman it is fixed in 1.37.113 and higher

@steveharman
Copy link

steveharman commented Apr 12, 2022 via email

@kjozwiak
Copy link
Member

kjozwiak commented Apr 13, 2022 •
edited
Loading

Verification PASSED on Pixel 6 running Android 12 using the following build(s):

Brave | 1.37.114 chromium: 100.0.4896.88 (official build) (32-bit)

Went through the STR/Cases outlined via #22128 (comment) & brave/brave-core#12920 (comment). Example:

Example Example Example Example
Screenshot_20220413-134014 Screenshot_20220413-134018 desktopSharing1 sharedOpened

Verification PASSED on Samsung Galaxy Tablet A running Android 12 using the following build(s):

Brave | 1.37.114 chromium: 100.0.4896.88 (official build) (32-bit)

Went through the STR/Cases outlined via #22128 (comment) & brave/brave-core#12920 (comment). Example:

Example Example Example Example
Screenshot_20220413-140551_Brave Screenshot_20220413-140558_Brave sharing1 sharing2

@kjozwiak kjozwiak mentioned this issue Apr 15, 2022
Closed
@marc0der
Copy link

Hi @samartnik @kjozwiak sadly this is still broken in 1.37.113. The verification only seemed to be for 114. If that indeed fixes it, when will this be released? This is a feature that I hugely rely on and would love to see working again.

@AdnanHodzic
Copy link

I can also confirm problem is still here on 1.37.113.

@bsclifton
Copy link
Member

bsclifton commented Apr 26, 2022 •
edited
Loading

cc: @mkarolin @emerick @samartnik

@marc0der
Copy link

This has been resolved now, thanks all!

@bsclifton
Copy link
Member

bsclifton commented Apr 26, 2022 •
edited
Loading

1.37.116 is out now - so we should be good to go 😄

@bsclifton bsclifton reopened this Apr 26, 2022
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.37.116
9080753 
 - Improved general performance by fixing cosmetic filters. ([#22030](brave/brave-browser#22030))
 - Added "Enable Tab Group auto creation" setting under "Appearance" which controls the ability to open links in separate tabs. ([#22105](brave/brave-browser#22105))
 - Fixed rounding issues under Brave Wallet via the "Send" and "Swap" panels by increasing the digits after the decimal to 0.00000000 (8 digits) from 0.000000 (6 digits). ([#22257](brave/brave-browser#22257))
 - Fixed crash when attempting to send opened tab to another devices on sync chain using "Send to your devices". ([#22128](brave/brave-browser#22128))
 - Upgraded Chromium to 100.0.4896.127. ([#22318](brave/brave-browser#22318)) ([Changelog for 100.0.4896.127](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.88..100.0.4896.127?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
bug crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include
Projects
None yet
Milestone
1.37.x - Release #6
Development

Successfully merging a pull request may close this issue.

[Android] Fixed crash on sending tabs to another device brave/brave-core
6 participants
@marc0der @AdnanHodzic @kjozwiak @bsclifton @steveharman @samartnik