Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapping on Load new content takes users to second card in feed rather than at the beginning of feed #22183

Closed
kjozwiak opened this issue Apr 8, 2022 · 3 comments · Fixed by brave/brave-core#13155

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Description

This is another follow up to #20408 & #21403 to basically fix the original issue on the tablet. As per the verification notes via brave/brave-core#12852 (comment), you'll notice that brave/brave-core#12852 didn't fix the issue on the tablet. Rather than moving the user to the top of the feed as expected, it's moving users to the second card in the feed rather than at the top as expected.

Steps to reproduce

  1. Install Brave and enable Brave News via Settings
  2. once enabled, scroll through the feed and select the Brave News Settings hamburger menu
  3. enable several random news feeds and back to Brave News by pressing <-- (or close Settings using the X)
  4. tap on the Load new content button

Actual result

XRecorder_08042022_011228.mp4

Expected result

When a user taps on Load new content, the feed should be refreshed and the view port should start at the top of the Brave News feed and not on the second card within the feed,

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy Tablet A
  • Android version: Android 12

Brave version

1.39.42 Chromium: 100.0.4896.79

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @bsclifton @alexsafe @tapanmodh @anthonypkeane @brave/qa-team

@Uni-verse
Copy link
Contributor

Able to reproduce this issue on version 1.39.42 Chromium: 100.0.4896.79 using STR from above on Samsung Galaxy Tab S7 running Android 12

  • Tapping on Load new content takes user to second card in news feed.

@Uni-verse
Copy link
Contributor

Verified using version

Brave	1.38.113 Chromium: 101.0.4951.61 (Official Build) (64-bit) 
Revision	3b3633b32c491b4cba5fd7df3c7c0f628547cbcc-refs/branch-heads/4951@{#1189}
OS	Android 12; Build/SP1A.210812.016
  • Ensured changing sources and tapping on Load new content takes user to the beginning of feed rather than second card.
22183_fix0.mp4

@kjozwiak
Copy link
Member Author

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.38.118 Chromium: 101.0.4951.67 (Official Build) (64-bit)
--- | ---
Revision | 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS | Android 12; Build/SP1A.210812.016

Went through the STR/Cases outlined via #22183 (comment) and ensured that tapping on Load new content took the user to the start of the news feed rather than the second/third card.

Screen_Recording_20220515-234139_Brave.mp4

Verification PASSED on Samsung Galaxy Tablet A running Android 11 using the following build(s):

Brave | 1.38.118 Chromium: 101.0.4951.67 (Official Build) (64-bit)
--- | ---
Revision | 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS | Android 11; Build/RP1A.200720.012

Went through the STR/Cases outlined via #22183 (comment) and ensured that tapping on Load new content took the user to the start of the news feed rather than the second/third card.

XRecorder_15052022_235122.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants