Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need a better way to copy addresses on wallet #22740

Closed
HEagle18 opened this issue May 8, 2022 · 4 comments · Fixed by brave/brave-core#13840 or brave/brave-core#13986
Closed

Need a better way to copy addresses on wallet #22740

HEagle18 opened this issue May 8, 2022 · 4 comments · Fixed by brave/brave-core#13840 or brave/brave-core#13986
Assignees
@HEagle18
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@HEagle18
Copy link

HEagle18 commented May 8, 2022

Description

Feedback from employee:

The “Copy to Clipboard” hover is a bit confusing. You see this when you hover over the address. If you try to move the mouse to the hover text, the hover text disappears. If you click over the address, there is no feedback that the address has been copied.

Steps to Reproduce

  1. Try and copy your address from the wallet

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 changed the title Need a better way to copy addresses Need a better way to copy addresses on wallet May 8, 2022
@HEagle18 HEagle18 added the feature/web3/wallet Integrating Ethereum+ wallet support label May 8, 2022
@jamesmudgett jamesmudgett added priority/P4 Planned work. We expect to get to it "soon". front-end-change This task is a front end task and doesn't need any C++ changes labels May 20, 2022
@muliswilliam muliswilliam added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 9, 2022
@muliswilliam
Copy link

muliswilliam commented Jun 9, 2022 •
edited
Loading

@HEagle18 We can add a copy icon, show on Copy to clipboard on hover. The icon should change to indicate a successful copy action. I have added design/need-mock-up label, when the mock up is ready, I can pick this up.

copy.address.phantom.mov

@muliswilliam muliswilliam mentioned this issue Jun 17, 2022
Merged
25 tasks
@muliswilliam muliswilliam added this to the 1.41.x - Beta milestone Jun 17, 2022
@HEagle18
Copy link
Author

This works on wallet page but not on portal. I'm on 1.42

@muliswilliam muliswilliam mentioned this issue Jun 28, 2022
Merged
25 tasks
@muliswilliam muliswilliam reopened this Jun 28, 2022
@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2022

Removing milestone based on #22740 (comment). Should probably require an uplift for 1.41.x if we do plan to ship it in 1.41.x.

@srirambv srirambv removed this from the 1.41.x - Beta milestone Jul 5, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 15, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Linux
  • Verified steps from brave/brave-core#13986
  • Verified clicking on an address shows Copied message
  • Verified on various screens where account address is shown
22740-Linux.MP4

Verification passed on

Brave 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from brave/brave-core#13986
  • Verified clicking on an address shows Copied message
  • Verified on various screens where account address is shown
22740-Windows.mp4

Verification passed on

Brave 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#13986
  • Verified clicking on an address shows Copied message
  • Verified on various screens where account address is shown
22740-macOS.mov

@LaurenWags LaurenWags mentioned this issue Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HEagle18 HEagle18

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.43.x - Release
5 participants
@jamesmudgett @HEagle18 @srirambv @brave-builds @muliswilliam