Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube.com on YouTube gets added to Auto-Contribute list #22859

Closed
Miyayes opened this issue May 16, 2022 · 4 comments · Fixed by brave/brave-core#16774
Closed

youtube.com on YouTube gets added to Auto-Contribute list #22859

Miyayes opened this issue May 16, 2022 · 4 comments · Fixed by brave/brave-core#16774
Assignees
Labels
bug feature/rewards greaselion OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 16, 2022

Description

STR:

  1. Opened a fairly new/fresh profile on
Brave 1.40.56 Chromium: 101.0.4951.67 (Official Build) nightly (x86_64)
Revision 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS macOS Version 12.3 (Build 21E230)
  1. Tried to test Auto-Contribute with YouTube video: https://www.youtube.com/watch?v=fAfOurUEcM8 from verified YouTube channel
  2. Saw youtube.com on YouTube entry get added to A-C list. Shortly after, I saw "Vice News" properly added (see screenshot). Perhaps it didn't pick up Vice channel info yet, so just added youtube.com generically to the A-C list, and then once it detected Vice channel info, then it added Vice on YouTube as a separate item on the A-C list?

Expected result

Never see youtube.com on YouTube get added to the A-C list. (If YouTube itself has a YouTube channel, then it would be YouTube on YouTube, but not youtube.com on Youtube, which looks like a bug.)

Screenshot

image

@Miyayes Miyayes added bug feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels May 16, 2022
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. greaselion labels May 18, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented May 18, 2022

Check if it's greaselion, or filters on the tab listeners. (zenparsing)

@zenparsing
Copy link

In 1.49.x with a fresh profile I saw the following in the AC list:

Screen Shot 2023-01-12 at 5 24 32 PM

It looks like perhaps the YouTube on YouTube issue has been fixed but we still don't necessary filter out the social platform site from AC.

@LaurenWags
Copy link
Member

LaurenWags commented Feb 13, 2023

Verified with

Brave | 1.49.92 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | macOS Version 12.6.3 (Build 21G419)

Unable to reproduce issue using STR with 1.48.158 Chromium: 110.0.5481.77 (current release version).

Also ran STR on 1.49.92 Chromium: 110.0.5481.77 and confirmed no youtube.com on YouTube creator listed in Auto-Contribute list:

AC

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 14, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.1pk_1.49.116

  • Confirmed no youtube.com on YouTube creator listed in Auto-Contribute list:
Example Example
Screenshot_20230303-165240_Brave - Beta Screenshot_20230303-165320_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards greaselion OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
6 participants