Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Rewards auto-contribute measurement #16774

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Jan 20, 2023

Resolves brave/brave-browser#22859
Resolves brave/brave-browser#27907
Resolves brave/brave-browser#27981

  • Removes native handlers for Twitch, Vimeo, and Reddit. These handlers no longer function.
  • Removes POST data listener that was only used for Twitch and Vimeo.
  • Uses publisher_utils.h for all URL-to-publisher mappings.
  • Uses publisher_utils.h for determining whether or not to allow tab events to measure AC.

Note: brave-ios will need to be updated as isMediaURL and reportPostData have been removed from the BraveLedger interface.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

For brave/brave-browser#27907:

  • Open the browser with a fresh profile.
  • Navigate to any "publisher" site.
  • Open the Rewards panel and enable Rewards.
  • Wait for a few seconds (in order to satisfy the "minimum publisher visit" time).
  • Navigate to a new URL.
    • Note: navigating away from the previous site is required, as the AC time is not measured until the tab is closed, hidden, or navigated.
  • Open the Rewards panel.
  • Verify that the "publishers visited" count is displayed with a value of 1.

@zenparsing zenparsing requested review from a team and iefremov as code owners January 20, 2023 20:12
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 5a376ccf7beceb98523847e3dcbc1d8261636a3f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

3 similar comments
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 5a376ccf7beceb98523847e3dcbc1d8261636a3f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 5a376ccf7beceb98523847e3dcbc1d8261636a3f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 5a376ccf7beceb98523847e3dcbc1d8261636a3f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

@github-actions github-actions bot added CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Jan 20, 2023
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 5a376ccf7beceb98523847e3dcbc1d8261636a3f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

@zenparsing zenparsing force-pushed the ksmith-ac-fixes branch 2 times, most recently from b57ef02 to 618f668 Compare January 23, 2023 16:50
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 618f6688a4d7fa5301fed3d7d1d9656bcd1359f5
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
4 participants