-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Rewards auto-contribute measurement #16774
Conversation
|
3 similar comments
|
|
|
vendor/bat-native-ledger/src/bat/ledger/internal/ledger_impl.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/legacy/static_values.h
Outdated
Show resolved
Hide resolved
|
b57ef02
to
618f668
Compare
|
618f668
to
0d8a98c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0d8a98c
to
54d8f15
Compare
Resolves brave/brave-browser#22859
Resolves brave/brave-browser#27907
Resolves brave/brave-browser#27981
publisher_utils.h
for all URL-to-publisher mappings.publisher_utils.h
for determining whether or not to allow tab events to measure AC.Note: brave-ios will need to be updated as
isMediaURL
andreportPostData
have been removed from theBraveLedger
interface.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
For brave/brave-browser#27907: