Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet unit-tests are broken #23624

Closed
onyb opened this issue Jun 23, 2022 · 0 comments · Fixed by brave/brave-core#13915
Closed

Wallet unit-tests are broken #23624

onyb opened this issue Jun 23, 2022 · 0 comments · Fixed by brave/brave-core#13915
Assignees
@onyb
Labels
bug front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/exclude
Milestone
1.40.x - Release #3

Comments

@onyb
Copy link
Member

onyb commented Jun 23, 2022

Following brave/brave-core#13873, wallet unit-tests are broken.

The failed test was marked as success on the CI, which is why we didn't notice it while merging. Here's the pipeline: https://ci.brave.com/blue/organizations/jenkins/pr-brave-browser-f-wallet-unlimited-allowance-macos/detail/pr-brave-browser-f-wallet-unlimited-allowance-macos/2/pipeline/190. cc: @mihaiplesa Is that normal?

Screenshot 2022-06-23 at 8 31 37 AM
@onyb onyb added bug QA/No release-notes/exclude OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 23, 2022
@onyb onyb self-assigned this Jun 23, 2022
@onyb onyb added this to Web3 Jun 23, 2022
@onyb onyb mentioned this issue Jun 23, 2022
Merged
25 tasks
@onyb onyb moved this to In Review in Web3 Jun 23, 2022
Repository owner moved this from In Review to Done in Web3 Jun 23, 2022
@onyb onyb added this to the 1.42.x - Nightly milestone Jun 23, 2022
This was referenced Jun 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.40.x - Release #3
Development

Successfully merging a pull request may close this issue.

fix(wallet): fix broken unit-tests due to locale alias brave/brave-core
2 participants
@kjozwiak @onyb