Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): fix formatting of unlimited token allowance #13873

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Jun 21, 2022

Resolves brave/brave-browser#23562
Resolves brave/brave-browser#22791

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

QA

Before

After

@onyb onyb self-assigned this Jun 21, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jun 21, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb force-pushed the f/wallet/unlimited-allowance branch from 417d6b0 to 235d527 Compare June 21, 2022 11:16
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb added this to the 1.42.x - Nightly milestone Jun 21, 2022
@onyb onyb merged commit c9750b6 into master Jun 21, 2022
@onyb onyb deleted the f/wallet/unlimited-allowance branch June 21, 2022 13:23
brave-builds pushed a commit that referenced this pull request Jun 21, 2022
brave-builds pushed a commit that referenced this pull request Jun 21, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.42.16 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS Windows 11 Version 21H2 (Build 22000.739)
  • Verified Unlimited is shown instead of the whole value for Approval transactions
  • Verified Approved is replaced by Swap on the transactions history in panel
brave/brave-browser#23562 brave/brave-browser#22791
13873.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants