-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tip not shown in Summary on settings page when Payments data imported from muon #2368
Comments
@LaurenWags do you know if there's a way to recover from this state once a user runs into this issue? I think I remember you mentioning that you never ended up seeing anything in the summary. If there's no way of recovering, I think this is a high priority as we'll have a large % of users stuck in this state eventually. @rebron @bsclifton if there's a hotfix being planned before we do another phase of migrations, this should be at least investigated IMO. @LaurenWags thoughts? |
@rebron moved this into |
@kjozwiak I will take a look later today |
@LaurenWags Does this happen when you manually import payments from muon (or was this from the auto update)? |
@rebron - reproduces when auto updating from muon, manually importing (thru Import Bookmarks and Settings), and launching brave with |
@LaurenWags thanks for double checking 👍 @rebron definitely need to get this fixed as we're encouraging users to migrate their date over. @NejcZdovc mentioned that he'll be looking at this so hopefully we can get this fixed before the release. |
Verified passed with
Verification passed on
Verification passed on
|
Description
If you import Payments data from muon, and then tip a site (one time tip), the tip does not display in your Rewards Summary. Instead, you see the 'Sadly, no tokens' message.
Steps to Reproduce
Actual result:
Tip is not recorded in Rewards Summary on brave://rewards or via the BAT logo:
![screen shot 2018-12-05 at 10 55 46 am](https://user-images.githubusercontent.com/28145373/49526938-d9e48500-f87e-11e8-8540-3857979720af.png)
Expected result:
Tip should be recorded in summary.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
If you perform the steps with a fresh wallet created on 0.57.x (not imported from muon), the tip displays in the Rewards Summary:
![screen shot 2018-12-05 at 11 15 39 am](https://user-images.githubusercontent.com/28145373/49527058-1e702080-f87f-11e8-8cc4-6ccc8c4e8aa3.png)
![screen shot 2018-12-05 at 11 15 33 am](https://user-images.githubusercontent.com/28145373/49527064-216b1100-f87f-11e8-8bb7-56c8e61d2811.png)
The text was updated successfully, but these errors were encountered: