Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation service to Brave #23813

Closed
rebron opened this issue Jun 30, 2022 · 13 comments
Closed

Add translation service to Brave #23813

rebron opened this issue Jun 30, 2022 · 13 comments
Assignees
@rebron
Labels
brave-translate OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 30, 2022 •
edited
Loading

Description

We have a translation service that is available in Nightly 1.42.x which can be enabled via brave://flags/#brave-translate-go

Some specific issues have been captured and labeled with brave-translate

This issue is intended to track work required before we can release Brave Translate

Test Plan

https://docs.google.com/document/d/1hADNy20_UIXMe2vXFrTFfpB5NCGK6hBtNVXJBYIJLds/edit

  1. No UseBraveTranslateGo feature
    (Desktop) old bubble to suggest Google extension is used;
    (Android) no translate UI or attempts to translate pages;

  2. (Desktop) UseBraveTranslateGo + enabled Google Translate extension
    "Google Translate extension" should be used instead of the build-in translation

  3. (Desktop) Migration
    “Offer to translate pages that aren't in a language you read” preference should be enabled at the first launch with UseBraveTranslateGo feature (if was disabled before)
    The preference is now unsynced => old version users shouldn't have the preference changed.

  4. (Desktop) Enabled UseBraveTranslateGo feature
    In general, the behavior should be the same as in Chrome. The difference:

  • limited language support;
  • no google icon;
  • another engine to translate => translated text is expected to be different.

What should be checked:

  • foreign language detection (the bubble to translate should be shown when visiting a site in a language that is not listed under settings > languages)
  • manual translation from the bubble/context menu.
  • “Always Translate" for language (enable “always translate ” in bubble and navigate to a site in )
  • never translate option for language/site
  • UI elements interaction (i.e. change the translate direction/revert/etc)
  • Enabling/disabling translate on brave://settings
  • Translation from the context menu when page language wasn't detected

Brave version (brave://version info)

Target release 1.43.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@rebron rebron added OS/Desktop brave-translate priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Jun 30, 2022
@rebron rebron mentioned this issue Jun 30, 2022
Closed
@rebron rebron added this to the 1.43.x - Beta milestone Aug 11, 2022
@rebron rebron closed this as completed Aug 11, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 12, 2022 •
edited
Loading

Verification PASSED using

Brave | 1.43.67 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.856)

Bugs filed:
#24649
#24650
#24714
#24715

Test Case 1: Brave translate bubble appearance - PASSED

Dark1 Dark2 Light1 Light2
image image image image

Test Case 2: (Desktop) Enabled UseBraveTranslateGo feature - UI validation - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. visit brave://settings/languages
  5. verifiedFrench is not listed in the Order languages based on your preferences
  6. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  7. visit brave://translate-internals to confirm fr(French) is a supported language
  8. load a French language site https://www.lemonde.fr/
  9. confirmed Brave translate bubble is shown
  10. click (x) is dismiss the modal and reload the page to view the brave translate bubble
  11. hover over the Brave translate icon in the URL bar to show Translate this page text
  12. confirmed the bubble displays the language to be translated from the visited site - French along with English
  13. click hamburger menu to confirm following:
    • Choose another language
    • Always translate French
    • Never translate French
    • Never translate this site
    • Page is not French
  14. confirmed the languages listed in the drop drown for Language to translate into match to the supported languages in brave://translate-internals
Step 3 Step4-6 Step 7 Step9 Step 10
image image image image image

Test Case 3: No UseBraveTranslateGo feature via brave://settings/languages - PASSED

  1. Install 1.43.67
  2. launch Brave
  3. relaunch Brave to enable the flag #brave-translate-go via griffin
  4. visit brave://settings/languages
  5. verifiedFrench is not listed in the Order languages based on your preferences
  6. visit brave://translate-internals to confirm fr(French) is a supported language
  7. open brave://settings/languages and toggle OFF for Offer to translate pages that aren't in a language you read entry
  8. load a French language site https://www.lemonde.fr/
  9. confirmed Brave translate bubble is not displayed in the URL bar
  10. confirmed Google translate extension bubble not shown as well
Step 3 Step 5 Step 8 Step 9 Step 11&12
image image image image image

Test Case 4: Enabled UseBraveTranslateGo - Functionality for supported and unsupported languages

Case 1:Choose another language - Portuguese

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. open brave://settings/languages and leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site https://www.lemonde.fr/
  6. confirmed Brave translate bubble is shown
  7. click hamburger menu and select 'Choose another language' - 'Portuguese`
  8. click Translate
  9. default language English is replaced by Portuguese in the bubble
  10. home page is translated into Portuguese
  11. clicked few links to verify pages are translated into Portuguese as well
  12. activated speed reader icon and page rendered in speed reader mode
Step 6 Step 7 Step 9-10 Step 11 Step 12
image image image image image

Case 2: Always translate <supported language>

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. open brave://settings/languages and leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site https://www.lemonde.fr/
  6. confirmed Brave translate bubble is shown
  7. click hamburger menu and select Always translate French
  8. switch between French and English language and the translation worked as expected.
  9. functionality worked as expected compared to chrome's Google translate extension
Step 7 Step 8
image image

Case 3: Never translate <supported language>

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. open brave://settings/languages and leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site https://www.lemonde.fr/
  6. confirmed Brave translate bubble is shown
  7. click hamburger menu to select Never translate French option
  8. click on a link in the page
  9. confirmed Brave translate bubble no longer displayed in the URL bar
Step 7 Step 9
image image

Case 4: Never translate this site

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. open brave://settings/languages and leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site https://www.lemonde.fr/
  6. confirmed Brave translate bubble is shown
  7. click hamburger menu and select Never translate this site option
  8. click a link or reload the page
  9. confirmed Brave translate extension no longer displayed in the URL
Step 7 Step 9
image image

Case 5: Page is not <supported language> - French

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. open brave://settings/languages and leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site https://www.lemonde.fr/
  6. confirmed Brave translate bubble is shown
  7. click hamburger menu and select Page is not French
  8. select Hindi
Step 5 Step 6 Step 8
image image image

Case 6: Unsupported languages in brave://translate-internals - Korean - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. visit brave://translate-internals to confirm Korean language is not listed in Supported languages
  5. visit brave://settings/languages
  6. open brave://settings/languages and leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  7. visit a Korean language site https://segye.com
  8. confirmed Brave translate bubble is not displayed in the URL bar
Step 4 Step 6 Step8
image image image

Case 7: Language already listed in brave://settings/languages - Hindi - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. open brave://settings/languages
  5. click Add languages to add one of the supported languages hi (Hindi)
  6. Added language is listed
  7. visit Hindi language site https://www.dainiktribuneonline.com/
  8. confirmed Brave translate bubble is not displayed in the URL bar
  9. open brave://settings/languages and click on ellipsis for Hindi entry
  10. check the checkbox for Offer to translate pages in this language
  11. Return to the website `https://www.dainiktribuneonline.com/ and reload the page
  12. Brave translate bubble displayed in the URL bar
Step 5 Step 6 Step 7-8 Step9-10 Step 11-12
image image image image image

Test Case 5: Brave translate override over Google translate after enabling it

  1. clean profile
  2. launch Brave
  3. do not restart the browser (this is will enable Brave translate via griffin)
  4. keep Default selection in brave://flags/#brave-translate-go
  5. visit brave://translate-internals to confirm fr(French) is a supported language
  6. visit brave://settings/languages
    • verified French is not listed
    • verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  7. visit French language site https://www.lemonde.fr/
  8. Google translate extension displayed in the URL bar as expected
  9. restart the browser to enable Brave translate via griffin
  10. Brave translate extension bubble displayed for https://www.lemonde.fr/ when page loaded
Step 3 Step 6 Step7-8 Step 10
image image image image

Test Case 6: Upgrade from 1.42.95 --->1.43.67

  1. install 1.42.95
  2. launch brave
  3. load a French language site https://www.lemonde.fr/
  4. Google Translate extension bubble is shown in the URL bar as expected
  5. close the browser but do not close the tabs
  6. rename the profile folder to Beta
  7. launch Brave with 1.43.67
  8. open brave://settings/languages and leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  9. https://www.lemonde.fr/ site tab is loaded with Brave translate bubble is displayed in the URL bar
Step 1 Step 4 Step 8 Step 9
image image image image

Test Case 7 - Change OS - Portuguese

  1. Change OS to Portuguese
  2. clean profile
  3. launch Brave
  4. restart the browser to enable Brave translate via griffin
  5. visit English language site bbc.com
  6. confirmed Brave translate bubble is displayed in the URL bar
  7. confirmed options displayed in hamburger menu as expected in selected OS language Portuguese
Step 1 Step 7-8
image image

Always translate

Ex1 Ex2 Ex3
image image image

Choose another language

Ex1 Ex2
image image

Never translate in English

Ex1 Ex2
image image

Never translate this site

Ex1 Ex2
image image

Page is not English

Ex1 Ex2
image"> image

@rebron rebron self-assigned this Aug 15, 2022
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 16, 2022
@stephendonner
Copy link

stephendonner commented Aug 16, 2022 •
edited
Loading

Verification PASSED using

Brave 1.43.70 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Testcase 1 - Brave Translate extension appearance - PASSED

  • install 1.43.70
  • launch Brave
  • load brave://flags
  • flip Enable internal translate engine to Enabled
  • restart Brave
Screen Shot 2022-08-16 at 10 07 47 AM
Dark mode 1 Dark mode 2 Light mode 1 Light mode 2
Screen Shot 2022-08-16 at 10 15 18 AM Screen Shot 2022-08-16 at 10 15 41 AM Screen Shot 2022-08-16 at 10 14 39 AM Screen Shot 2022-08-16 at 10 14 43 AM

Testcase 2 - Enabled UseBraveTranslateGo feature - UI validation - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. visit brave://settings/languages
  5. verified German is not listed in the Order languages based on your preferences
  6. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  7. visit brave://translate-internals to confirm de (German) is a supported language
  8. load speigel.de
  9. confirmed Brave translate extension bubble is shown
  10. click (x) to dismiss the modal and reload the page to view the Brave translate extension bubble
  11. hover over the extension icon in the URL bar to show Translate this page text
  12. confirmed extension bubble displays the language to be translated from the visited site - German along with English
  13. click hamburger menu to confirm the following:
    • Choose another language
    • Always translate German
    • Never translate German
    • Never translate this site
    • Page is not German
  14. confirmed the languages listed in the drop drown for Language to translate into match to the supported languages in brave://translate-internals
step 3 steps 4-6 step 7 step 9 step 14
Screen Shot 2022-08-16 at 10 26 40 AM Screen Shot 2022-08-16 at 11 49 38 AM Screen Shot 2022-08-16 at 1 07 58 PM Screen Shot 2022-08-16 at 1 14 55 PM Screen Shot 2022-08-16 at 1 16 59 PM

Testcase 3 - no UseBraveTranslateGo feature via brave://settings/languages - PASSED

  1. install 1.43.70
  2. launch Brave
  3. relaunch Brave to enable the flag #brave-translate-go` via Griffin
  4. visit brave://settings/languages
  5. verified German is not listed in the Order languages based on your preferences
  6. visit brave://translate-internals to confirm de (German) is a supported language
  7. open brave://settings/languages and toggle OFF for Offer to translate pages that aren't in a language you read entry
  8. load www.speigel.de
  9. confirmed Brave translate extension is not displayed in the URL bar
  10. confirmed Google Translate extension bubble not shown
step 3 step 5 step 6 step 7 steps 9-10
Screen Shot 2022-08-16 at 1 40 11 PM Screen Shot 2022-08-16 at 1 41 27 PM Screen Shot 2022-08-16 at 1 45 58 PM Screen Shot 2022-08-16 at 1 47 06 PM Screen Shot 2022-08-16 at 1 47 58 PM

Testcase 4 - Enabled UseBraveTranslateGo feature - functionality - PASSED

Case 1: Choose another language - Dutch - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit Spanish language site laopinion.com
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select 'Choose another language' - Dutch
  8. click Translate
  9. default language English is replaced by Dutch in the extension bubble
  10. home page is translated into Dutch
  11. clicked few links to verify pages are translated into Dutch as well
  12. activated speed reader icon and page rendered in speed reader mode
step 6 step 7 steps 9-10 step 11 step 12
Screen Shot 2022-08-16 at 3 41 54 PM Screen Shot 2022-08-16 at 3 35 42 PM Screen Shot 2022-08-16 at 3 39 01 PM Screen Shot 2022-08-16 at 3 40 03 PM Screen Shot 2022-08-16 at 3 39 43 PM

Case 2: Always translate <supported language> - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Always translate French
  8. switch between French and English language and the translation worked as expected
  9. functionality worked as expected compared to Chrome's Google Translate extension
step 7 step 8
Screen Shot 2022-08-16 at 3 57 24 PM Screen Shot 2022-08-16 at 3 59 19 PM

Case 3: Never translate <supported language> - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Never translate French
  8. click on a link
  9. confirmed Brave translate extension no longer displayed in the URL bar
step 7 step 9
Screen Shot 2022-08-16 at 4 12 59 PM Screen Shot 2022-08-16 at 4 13 12 PM

Case 4: Never translate this site - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Never translate this site
  8. click a link or reload the page
  9. confirmed Brave translate extension no longer displayed in the URL
  10. loaded www.france24.com/fr and confirmed I still got the Brave translate UI
step 7 step 9 step 10
Screen Shot 2022-08-16 at 4 19 21 PM Screen Shot 2022-08-16 at 4 21 38 PM Screen Shot 2022-08-16 at 4 20 29 PM

Case 5: Page is not in <supported language> - PASSED (*)

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Page is Not in French
    ...

(*) See #24747

step 7 step 9

Case 6: Unsupported languages in brave://translate-internals - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. visit brave://translate-internals to confirm Korean language is not listed in Supported languages
  5. visit brave://settings/languages
  6. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  7. visit Korean language site www.segye.com
  8. confirmed Brave translate extension is not loaded
step 4 step 6 step 8
Screen Shot 2022-08-16 at 5 44 50 PM Screen Shot 2022-08-16 at 5 45 10 PM Screen Shot 2022-08-16 at 5 45 25 PM

Case 7: Language already listed in brave://settings/languages - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. open brave://settings/languages
  5. click Add languages to add one of the supported languages hi (Hindi)
  6. Added language is listed
  7. visit Hindi language site www.dainiktribuneonline.com
  8. confirmed Brave translate extension is not displayed in the URL bar
  9. open brave://settings/languages and click on ellipsis for Hindi entry
  10. check the checkbox for Offer to translate pages in this language
  11. Return to the website www.dainiktribuneonline.com and reload the page
  12. Brave translate extension displayed in the URL bar
step 5 step 6 steps 7-8 steps 9-10 steps 11-12
Screen Shot 2022-08-16 at 6 13 49 PM Screen Shot 2022-08-16 at 6 15 30 PM Screen Shot 2022-08-16 at 6 15 43 PM Screen Shot 2022-08-16 at 6 15 58 PM Screen Shot 2022-08-16 at 6 16 12 PM

Case 8: Translate to <supported language> context-menu item - PASSED

1. clean profile 2. launch Brave 3. restart the browser to enable `Brave translate` via Griffin 4. load `hoylosangeles.com` 5. context-click the page and select `Translate to English` 6. confirm the page is translated into English, from Spanish
step 5 step 6
Screen Shot 2022-08-17 at 10 28 41 AM Screen Shot 2022-08-17 at 10 24 50 AM

Testcase 5 - Brave translate overrides Google Translate after enabling it - PASSED

  1. clean profile
  2. launch Brave
  3. do not restart the browser (this is will enable Brave translate via Griffin)
  4. keep Default selection in brave://flags/#brave-translate-go
  5. visit brave://translate-internals to confirm es (Spanish) is a supported language
  6. visit brave://settings/languages
  • verified Spanish is not listed
  • verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  1. visit Spanish language site www.bbc.com/mundo
  2. Google Translate extension displayed in the URL bar as expected
  3. restart the browser to enable Brave translate via Griffin
  4. Brave translate extension bubble displayed for www.bbc.com/mundo when page loaded
step 3 step 6 steps 7-8 step 10
Screen Shot 2022-08-16 at 8 01 05 PM Screen Shot 2022-08-16 at 8 02 06 PM Screen Shot 2022-08-16 at 8 07 02 PM Screen Shot 2022-08-16 at 8 07 10 PM

Testcase 6 - Upgrade from 1.42.95 --> 1.43.71 - PASSED

  1. install 1.42.95
  2. launch Brave
  3. load a Russian language site www.mail.ru
  4. Google Translate extension bubble is shown in the URL bar as expected
  5. close the browser but do not close the tabs
  6. rename the profile folder to Brave-Browser-Beta
  7. launch Brave with 1.43.71
  8. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  9. mail.ru site tab is loaded with Brave translate extension bubble is displayed in the URL bar
step 4 step 9
Screen Shot 2022-08-16 at 5 16 47 PM Screen Shot 2022-08-16 at 5 20 12 PM

Testcase 7 - Change OS language - PASSED

  1. change macOS language to Spanish
  2. clean profile
  3. launch Brave
  4. restart the browser to enable Brave translate via Griffin
  5. visit English language site www.bbc.com
  6. confirmed Brave translate bubble is displayed in the URL bar
  7. confirmed bubble options displayed in selected in OS language Spanish
step 1 steps 6-7
Captura de Pantalla 2022-08-16 a la(s) 8 50 30 p  m Captura de Pantalla 2022-08-17 a la(s) 8 46 00 a  m

Always translate

example example
Captura de Pantalla 2022-08-17 a la(s) 8 49 15 a  m Captura de Pantalla 2022-08-17 a la(s) 8 49 25 a  m

Choose another language

example example
Captura de Pantalla 2022-08-17 a la(s) 9 07 00 a  m Captura de Pantalla 2022-08-17 a la(s) 9 07 07 a  m

Never translate in English

example example
Captura de Pantalla 2022-08-17 a la(s) 8 51 25 a  m Captura de Pantalla 2022-08-17 a la(s) 8 52 26 a  m

Never translate this site

example example
Captura de Pantalla 2022-08-17 a la(s) 8 53 16 a  m Captura de Pantalla 2022-08-17 a la(s) 9 00 54 a  m

Page is not in English

example example
Captura de Pantalla 2022-08-17 a la(s) 9 08 43 a  m Captura de Pantalla 2022-08-17 a la(s) 9 08 56 a  m

Encountered/logged:

@stephendonner stephendonner mentioned this issue Aug 17, 2022
Closed
@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 17, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.43.78 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Ubuntu 18.04 LTS

Testcase 1 - Brave Translate extension appearance - PASSED

  • install 1.43.x
  • launch Brave
  • load brave://flags
  • flip Enable internal translate engine to Enabled
  • restart Brave

image

image
image
image
image

Testcase 2 - Enabled UseBraveTranslateGo feature - UI validation - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via griffin
  4. visit brave://settings/languages
  5. verified German is not listed in the Order languages based on your preferences
  6. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  7. visit brave://translate-internals to confirm de (German) is a supported language
  8. load speigel.de
  9. confirmed Brave translate extension bubble is shown
  10. click (x) to dismiss the modal and reload the page to view the Brave translate extension bubble
  11. hover over the extension icon in the URL bar to show Translate this page text
  12. confirmed extension bubble displays the language to be translated from the visited site - German along with English
  13. click hamburger menu to confirm the following:
    • Choose another language
    • Always translate German
    • Never translate German
    • Never translate this site
    • Page is not German
  14. confirmed the languages listed in the drop drown for Language to translate into match to the supported languages in brave://translate-internals

image
image
image
image
image
image

Testcase 3 - no UseBraveTranslateGo feature via brave://settings/languages - PASSED

  1. install 1.43.x
  2. launch Brave
  3. relaunch Brave to enable the flag #brave-translate-go` via Griffin
  4. visit brave://settings/languages
  5. verified German is not listed in the Order languages based on your preferences
  6. visit brave://translate-internals to confirm de (German) is a supported language
  7. open brave://settings/languages and toggle OFF for Offer to translate pages that aren't in a language you read entry
  8. load www.speigel.de
  9. confirmed Brave translate extension is not displayed in the URL bar
  10. confirmed Google Translate extension bubble not shown

image
image

Testcase 4 - Enabled UseBraveTranslateGo feature - functionality - PASSED

Case 1: Choose another language - Dutch - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit Spanish language site laopinion.com
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select 'Choose another language' - Dutch
  8. click Translate
  9. default language English is replaced by Dutch in the extension bubble
  10. home page is translated into Dutch
  11. clicked few links to verify pages are translated into Dutch as well
  12. activated speed reader icon and page rendered in speed reader mode

image
image

Case 2: Always translate <supported language> - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Always translate French
  8. switch between French and English language and the translation worked as expected
  9. functionality worked as expected compared to Chrome's Google Translate extension

image
image

Case 3: Never translate <supported language> - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Never translate French
  8. click on a link
  9. confirmed Brave translate extension no longer displayed in the URL bar

image
image

Case 4: Never translate this site - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Never translate this site
  8. click a link or reload the page
  9. confirmed Brave translate extension no longer displayed in the URL
  10. loaded www.france24.com/fr and confirmed I still got the Brave translate UI

image
image
image

Case 5: Page is not in <supported language> - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. leave toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  5. visit French language site www.lemonde.fr
  6. confirmed Brave translate extension bubble is shown
  7. click hamburger and select Page is Not in French

image
image

Case 6: Unsupported languages in brave://translate-internals - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. visit brave://translate-internals to confirm Korean language is not listed in Supported languages
  5. visit brave://settings/languages
  6. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  7. visit Korean language site www.segye.com
  8. confirmed Brave translate extension is not loaded

image

Case 7: Language already listed in brave://settings/languages - PASSED

  1. clean profile
  2. launch Brave
  3. restart the browser to enable Brave translate via Griffin
  4. open brave://settings/languages
  5. click Add languages to add one of the supported languages hi (Hindi)
  6. Added language is listed
  7. visit Hindi language site www.dainiktribuneonline.com
  8. confirmed Brave translate extension is not displayed in the URL bar
  9. open brave://settings/languages and click on ellipsis for Hindi entry
  10. check the checkbox for Offer to translate pages in this language
  11. Return to the website www.dainiktribuneonline.com and reload the page
  12. Brave translate extension displayed in the URL bar

image
image
image
image

Case 8: Translate to <supported language> context-menu item - PASSED

1. clean profile 2. launch Brave 3. restart the browser to enable `Brave translate` via Griffin 4. load `hoylosangeles.com` 5. context-click the page and select `Translate to English` 6. confirm the page is translated into English, from Spanish

image
image

Testcase 5 - Brave translate overrides Google Translate after enabling it - PASSED

  1. clean profile
  2. launch Brave
  3. do not restart the browser (this is will enable Brave translate via Griffin)
  4. keep Default selection in brave://flags/#brave-translate-go
  5. visit brave://translate-internals to confirm es (Spanish) is a supported language
  6. visit brave://settings/languages
  • verified Spanish is not listed
  • verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  1. visit Spanish language site www.bbc.com/mundo
  2. Google Translate extension displayed in the URL bar as expected
  3. restart the browser to enable Brave translate via Griffin
  4. Brave translate extension bubble displayed for www.bbc.com/mundo when page loaded

image

image
image

Testcase 6 - Upgrade- PASSED

  1. install 1.42.x
  2. launch Brave
  3. load a Russian language site www.mail.ru
  4. Google Translate extension bubble is shown in the URL bar as expected
  5. close the browser but do not close the tabs
  6. rename the profile folder to Brave-Browser-Beta
  7. launch Brave with 1.43.x
  8. verified toggle ON as a default for Offer to translate pages that aren't in a language you read entry
  9. mail.ru site tab is loaded with Brave translate extension bubble is displayed in the URL bar

image
image

Testcase 7 - Change OS language - PASSED

  1. change language
  2. clean profile
  3. launch Brave
  4. restart the browser to enable Brave translate via Griffin
  5. visit English language site www.bbc.com
  6. confirmed Brave translate bubble is displayed in the URL bar
  7. confirmed bubble options displayed in selected in OS language Polish

image
image

@LaurenWags LaurenWags mentioned this issue Aug 31, 2022
Closed
@UjCbFwtBayFM
Copy link

UjCbFwtBayFM commented Sep 1, 2022 •
edited
Loading

Is it done locally, hosted by Brave or is it relayed elsewhere? There is no documentation about this.

@skariko
Copy link

skariko commented Sep 2, 2022 •
edited
Loading

Doesn't seem to work. The prompt for language translation shows to install Google Translate extension

Same on Windows 10 and Brave 1.43.88

@emacsomancer
Copy link

Similarly does not seem to be on by default in Linux.

Does brave://flags/#brave-translate-go still need to be manually set in this version?

@atuchin-m atuchin-m mentioned this issue Sep 12, 2022
Closed
@atuchin-m
Copy link
Contributor

@emacsomancer @skariko @8227846265
The PR to enable the feature for 100% audience have been merged recently.

All actual browser versions should have Translate feature available now (Desktop & Android). You don't need to set brave://flags/#brave-translate-go manually.
If it doesn't work for you please restart you browser and check you have the latest version.

We're still working supporting the rest languages: #24303

@UjCbFwtBayFM
Copy link

@emacsomancer @skariko @8227846265 The PR to enable the feature for 100% audience have been merged recently.
It would have been nice to mention the progressive roll-out of this feature in a more visible channel, like the release notes.

@atuchin-m
Copy link
Contributor

@rebron have we mentioned the launch somewhere?

@atuchin-m
Copy link
Contributor

atuchin-m commented Sep 12, 2022 •
edited
Loading

Is it done locally, hosted by Brave or is it relayed elsewhere? There is no documentation about this.

It's a brave hosted solutions from Lingvanex.
I'm updating the docs here: brave/go-translate#19

@bsclifton
Copy link
Member

@atuchin-m can you please update the docs here too?
https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)

Thanks 😄

@rebron rebron mentioned this issue Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebron rebron

Labels
brave-translate OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.43.x - Release
Development

No branches or pull requests
11 participants
@stephendonner @bsclifton @rebron @emacsomancer @UjCbFwtBayFM @skariko @LaurenWags @btlechowski @atuchin-m @MadhaviSeelam and others