Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional language pairs to Brave Translate #24303

Closed
rebron opened this issue Jul 27, 2022 · 15 comments
Closed

Add additional language pairs to Brave Translate #24303

rebron opened this issue Jul 27, 2022 · 15 comments
Assignees
Labels

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 27, 2022

Description

Add remaining 93 language pairs to Brave Translate. Total of 108 language pairs.

Steps to Reproduce

Visit brave://translate-internals

Currently we have (15):
de (German)
en (English)
es (Spanish)
fr (French)
hi (Hindi)
it (Italian)
ja (Japanese)
nl (Dutch)
pl (Polish)
pt (Portuguese)
ro (Romanian)
ru (Russian)
tr (Turkish)
vi (Vietnamese)
zh-Hans

Expected result:

1 Afrikaans
2 Albanian
3 Amharic
4 Arabic
5 Armenian
6 Azerbaijani
7 Basque
8 Belarusian
9 Bengali (or Bangladeshi)
10 Bosnian
11 Bulgarian
12 Catalan (Valencian)
13 Cebuano
14 Chichewa (or Nyanja)
15 Chinese (Simplied)
16 Chinese (Traditional)
17 Corsican
18 Croatian
19 Czech
20 Danish
21 Dutch
22 Esperanto
23 Estonian
24 Filipino (Tagalog)
25 Finnish
26 French
27 Frisian
28 Galician
29 Georgian
30 German
31 Greek
32 Gujarati
33 Haitian Creole
34 Hausa
35 Hawaiian
36 Hebrew
37 Hindi
38 Hmong
39 Hungarian
40 Icelandic
41 Igbo
42 Indonesian (or Bahasa Indonesia)
43 Irish
44 Italian
45 Japanese
46 Javanese
47 Kannada
48 Kazakh
49 Khmer (or Cambodian)
50 Kinyarwanda
51 Korean
52 Kurdish
53 Kyrgyz
54 Lao (Laos)
55 Latin
56 Latvian
57 Lithuanian
58 Luxembourgish
59 Macedonian
60 Malagasy
61 Malay (or Bahasa Melayu)
62 Malayalam
63 Maltese
64 Maori
65 Marathi
66 Mongolian
67 Myanmar (Burmese)
68 Nepali
69 Norwegian
70 Odia
71 Persian (or Iranian)
72 Polish
73 Portuguese
74 Punjabi (Panjabi)
75 Pushto (Pashto)
76 Romanian
77 Russian
78 Samoan
79 Scottish (Gaelic)
80 Serbian - Cyrillic
81 Sesotho
82 Shona
83 Sindhi
84 Sinhala (or Sinhalese)
85 Slovak
86 Slovenian
87 Somali
88 Spanish
89 Sundanese
90 Swahili
91 Swedish
92 Tajik
93 Tamil
94 Tatar
95 Telugu
96 Thai
97 Turkish
98 Turkmen
99 Ukrainian
100 Urdu
101 Uyghur
102 Uzbek
103 Vietnamese
104 Welsh
105 Xhosa
106 Yiddish
107 Yoruba
108 Zulu

Desktop Brave version:

Target 1.43.x

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added OS/Android Fixes related to Android browser functionality OS/Desktop brave-translate labels Jul 27, 2022
@rebron rebron assigned atuchin-m and unassigned moritzhaller Aug 16, 2022
@rebron
Copy link
Collaborator Author

rebron commented Aug 22, 2022

cc: @linhkikuchi

@mx202
Copy link

mx202 commented Aug 31, 2022

I hope they will support Arabic and other languages soon like Microsoft Edge does

@linhkikuchi
Copy link
Contributor

I hope they will support Arabic and other languages soon like Microsoft Edge does

Yes, we do have Arabic, all languages (from the above list) are supported, we can see it here on staging https://translate.bravesoftware.com/translate_a/l

@bsclifton
Copy link
Member

bsclifton commented Sep 15, 2022

@cc19264997
Copy link

Hello, when can I support Chinese translation? I need him very much, thank you!~~

@SWxEng
Copy link

SWxEng commented Oct 14, 2022

Hi
.
Pls fix a problem ​Arabic + Englisn in Translate Web.....
.
Desktop Brave version / 1.44.112 Chromium: 106.0.5249.119 (Official Build) (64-bit) 2022-10-12

@rebron
Copy link
Collaborator Author

rebron commented Oct 14, 2022

Closed with brave/brave-core#15433

@rebron rebron closed this as completed Oct 14, 2022
@rebron rebron added this to the 1.46.x - Nightly milestone Oct 14, 2022
@kjozwiak
Copy link
Member

The above requires 1.45.102 or higher for 1.45.x verification 👍

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 17, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 18, 2022

Verification PASSED using

Brave | 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
-- | --
Revision | fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Case 1: Verify Brave translate functionality with additional supported languages

  • Installed 1.45.104
  • Launch Brave
  • Verified translation functionality worked as expected for newly supported languages - Chinese (Traditional), Telugu, Portuguese, Afrikaans and Irish

Chinese (Traditional)

Visted https://www.ltn.com.tw/

Chinese (traditional) English
image image

Portuguese

visit https://www.publico.pt/

Portuguese English
image image

Telugu

Telugu English
image image

Afrikaans

Afrikaans English
image image

Irish

Irish English
image image

Case 2: Choose another language - Chinese --> Hindi

  • selected Another language -Hindi
  • page translated to successfully
Ex1 Ex2 Ex3
image image image

Case 3: Never translate

  • selected Never translate option in the hamburger menu
  • Brave translate icon disappeared when clicked on a link
Ex1 Ex2
image <image

Case 4: Always translate

  • selected Always translate option in the hamburger menu
  • switch between Afrikaans and English language and the translation worked as expected.
Ex1 Ex2
image image

Case 5: brave://translate-internals page lists newly supported languages, a total of 108 language pairs

  • brave://translate-internals page lists newly supported languages, a total of 108 language pairs. No errors logged on the page
Ex1 Ex2
image image

Case 6: Change OS - Turkish

  • Change OS to Turkish
  • clean profile
  • launch Brave
  • visit English language site bbc.com
  • confirmed Brave translate bubble is displayed in the URL bar
  • confirmed options displayed in hamburger menu as expected in selected OS language Turkish
  • translation worked as expected
Ex1 Ex2 Ex1 Ex2
image image image image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 20, 2022

Verification PASSED on vivo x70 Pro version 12 running Bravemonoarm64.apk_1.45.108

  • Verified the Description from the issue and ensured all the 108 language are added in an Alphabetic order
Example Example Example Example Example Example Example Example
Screenshot_20221020_211412 Screenshot_20221020_211420 Screenshot_20221020_211428 Screenshot_20221020_211439 Screenshot_20221020_211448 Screenshot_20221020_211455 Screenshot_20221020_211507 Screenshot_20221020_211513
Verify translation for few locales

cn.chinadaily.com.con

Chinese (simplified) Kannada
Screenshot_20221020_212708 Screenshot_20221020_212721

kannada.news18.com

Kannada Arabic
Screenshot_20221020_213410 Screenshot_20221020_213432

Additional testing is covered in #25347 (comment)

Never translate this page
  • Open any non english page
  • Ensure that the translate bubble is shown
  • Click on the 3 dot menu
  • Clck on Never translate this page
  • Ensure that the translate bubble is removed from the page
Example Example
Screenshot_20221020_225706 Screenshot_20221021_120936
Always translate the pages
  • Open any non english page
  • Ensure that the translate bubble is shown
  • Click on the 3 dot menu
  • Clck on Always translate this page
  • Ensure that the the info message is shown as "Pages in Hindi will be translated to English from now"
  • Ensured that the page translated to English
Example Example Example
Screenshot_20221020_225706 Screenshot_20221021_124641 Screenshot_20221021_124647

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.45.108

  • Verified the Description from the issue and ensured all the 108 language are added in an Alphabetic order
Example Example Example Example Example
Screenshot_20221021-132713_Brave Screenshot_20221021-132734_Brave Screenshot_20221021-132748_Brave Screenshot_20221021-132804_Brave Screenshot_20221021-132815_Brave
Verify translation for few locales

cn.chinadaily.com.con

Chinese (simplified) Kannada
Screenshot_20221021-133105_Brave Screenshot_20221021-133158_Brave

kannada.news18.com

Kannada Arabic
Screenshot_20221021-133158_Brave Screenshot_20221021-133220_Brave

Additional testing is covered in #25347 (comment)

Never translate this page
  • Open any non english page
  • Ensure that the translate bubble is shown
  • Click on the 3 dot menu
  • Clck on Never translate this page
  • Ensure that the translate bubble is removed from the page
Example Example Example
Screenshot_20221021-133413_Brave Screenshot_20221021-133428_Brave Screenshot_20221021-133442_Brave
Always translate the pages
  • Open any non english page
  • Ensure that the translate bubble is shown
  • Click on the 3 dot menu
  • Clck on Always translate this page
  • Ensure that the the info message is shown as "Pages in Hindi will be translated to English from now"
  • Ensured that the page translated to English
Example Example Example
Screenshot_20221021-133623_Brave Screenshot_20221021-133635_Brave Screenshot_20221021-133644_Brave

@biange200
Copy link

biange200 commented Oct 20, 2022 via email

@git10135405
Copy link

come on, hope translate others language to chinese simple!!

@m77e4t
Copy link

m77e4t commented Oct 25, 2022

One user has requested Kurdish Sorani (Kurdish Central) along with Kurdish Kurmanji (Kurdish Northern).
https://community.brave.com/t/enabling-central-kurdish-to-web-translation/434941/

Lingvanex only has Kurdish Kurmanji and not Kurdish Sorani. Kurmanji uses Latin alphabet while Sorani uses Kurdish Alphabet.
Google Translate has both Sorani and Kurmanji in its catalogue.

According to the user, Kurdish Sorani is the official language in some parts of the area https://en.m.wikipedia.org/wiki/Sorani

@git10135405
Copy link

安卓版 中国大陆翻译完全没法用!!!

@biange200
Copy link

安卓版 中国大陆翻译完全没法用!!!

只能选择翻墙,翻墙后,翻译速度也慢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests