Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for Prevent sites from fingerprinting me based on my language preferences #23919

Closed
srirambv opened this issue Jul 7, 2022 · 6 comments · Fixed by brave/brave-core#14398
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 7, 2022

Desktop has a setting Prevent sites from fingerprinting me based on my language preferences under shields which is missing on Android. Issue to track the implementation

cc: @ShivanKaul @pes10k @anthonypkeane @rebron @SergeyZhukovsky @Sam-Sibley

@srirambv srirambv added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Jul 7, 2022
@timchilds
Copy link

timchilds commented Jul 20, 2022

It makes sense to put this setting underneath the "Block fingerprinting" option in settings -> Brave Shields & privacy. The desktop header text seems a too long for the Android menu:

Prevent sites from fingerprinting me based on my language preferences
Enabling this setting reduces how much web sites can learn about your language preferences.

Maybe we can shorten to:

Prevent fingerprinting via language preferences
Enabling this setting reduces how much web sites can learn about your language preferences.

@rmcfadden3 I will defer to you for the final copy.

cc @Sam-Sibley

@rmcfadden3
Copy link

@timchilds — I like your version. Just a couple small tweaks, take em or leave em:

  • Header: Prevent fingerprinting via language settings
  • Body: Reduces how much websites can learn about you based on your browser's language settings.

@deeppandya
Copy link

@timchilds @anthonypkeane for this issue, we need to have brave-reduce-language flag enabled for android and it seems by default it's disabled. Should we enable it by default ? CC @srirambv @pes10k @pilgrim-brave

@pes10k
Copy link
Contributor

pes10k commented Aug 3, 2022

Would be good to have the feature flag disabled by default in code, but enabled via griffin. Once its been rolled out and tested, we can enable the feature flag by default

@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 9, 2022
@deeppandya
Copy link

This issue is addressed by brave/brave-core#14398

@kjozwiak
Copy link
Member

kjozwiak commented Sep 23, 2022

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
--- | ---
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Android 13; Build/T1B1.220819.006

Prevent sites from fingerprinting me based on my language preferences enabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923-011037 Screenshot_20220923-011646 Screenshot_20220923-011657 Screenshot_20220923-011714 Screenshot_20220923-011728

Prevent sites from fingerprinting me based on my language preferences disabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923-013253 Screenshot_20220923-013313 Screenshot_20220923-013335 Screenshot_20220923-013352 Screenshot_20220923-013407

Verification PASSED on Samsung Tab S8 Ultra running Android 12 using the following build(s):

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (32-bit)
--- | ---
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Android 12; Build/SP2A.220305.013

Prevent sites from fingerprinting me based on my language preferences enabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923_013851_Brave Screenshot_20220923_013922_Brave Screenshot_20220923_014020_Brave Screenshot_20220923_014041_Brave Screenshot_20220923_014052_Brave

Prevent sites from fingerprinting me based on my language preferences disabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923_014354_Brave Screenshot_20220923_014424_Brave Screenshot_20220923_014458_Brave Screenshot_20220923_014507_Brave Screenshot_20220923_014521_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants