Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user pref for debouncing feature #24020

Closed
ShivanKaul opened this issue Jul 12, 2022 · 6 comments · Fixed by brave/brave-core#15905
Closed

Add user pref for debouncing feature #24020

ShivanKaul opened this issue Jul 12, 2022 · 6 comments · Fixed by brave/brave-core#15905

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Jul 12, 2022

Add a new pref to control debouncing to brave://settings/shields. Currently we only have a flag in brave://flags for debouncing.

Setting label: Auto-redirect tracking URLs
Sublabel: Enable support for bypassing top-level redirect tracking URLs. Learn More. Learn more points to https://brave.com/privacy-updates/11-debouncing/

Note that De-AMP related debouncing (e.g. debounce AMP cache URLs) would depend on both this new Debounce setting (to debounce at all) and the De-AMP setting prescribed by the pref key in debounce.json, support for which was added in #23121.

@ShivanKaul ShivanKaul added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 12, 2022
@ShivanKaul ShivanKaul self-assigned this Jul 12, 2022
@ShivanKaul ShivanKaul changed the title Add user pref for debouncing feature Add user pref for debouncing feature (Desktop) Nov 11, 2022
@ShivanKaul ShivanKaul removed the OS/Android Fixes related to Android browser functionality label Nov 11, 2022
@ShivanKaul ShivanKaul added the OS/Android Fixes related to Android browser functionality label Dec 6, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 9, 2022
@LaurenWags
Copy link
Member

@ShivanKaul is using https://dev-pages.brave.software/navigation-tracking/debouncing.html sufficient for testing the pref on/off setting?

cc @brave/qa-team

@ShivanKaul
Copy link
Collaborator Author

Yeah that makes sense. Also apologies, this should be Desktop and Android, I updated the PR but forgot to update the issue.

@ShivanKaul ShivanKaul changed the title Add user pref for debouncing feature (Desktop) Add user pref for debouncing feature Jan 14, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 17, 2023

Verification PASSED using

Brave | 1.48.129 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Case 1: Enable Auto-redirect tracking URLs - PASSED

  1. Install 1.48.129
  2. launch Brave
  3. navigate to brave://settings/shields
  4. confirmed Auto-redirect tracking URLs setting is toggled On/Enabled as a default
  5. confirmed Enable support for bypassing top-level redirect tracking URLs.' sub label text with Learn more more link displayed
  6. clicked on Learn more, navigated to https://brave.com/privacy-updates/11-debouncing/
  7. visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
  8. click Run for all the conditions (Default, Base 64, Regex & Regex (multi)
  9. click other site and Run the same conditions

Confirmed redirecting worked as expected with Auto-redirect tracking URLs default setting

step 4-5 step 6 step 8 step 9
image image image image

Case 2: Disable Auto-redirect tracking URLs - PASSED

  1. Continue from Case 1:
    • Auto-redirect tracking URLs setting in brave://settings/shields enabled
  2. disable Auto-redirect tracking URLs setting
  3. visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
  4. click Run for Default condition

Confirmed redirecting didn't work with disabling Auto-redirect tracking URLs pref

step 2 step 3 step 4 ex ex
image image image image image

@stephendonner
Copy link

stephendonner commented Jan 18, 2023

Verification PASSED using

Brave 1.48.129 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Case 1: Enable Auto-redirect tracking URLs - PASSED

  1. Install 1.48.129
  2. launch Brave
  3. navigate to brave://settings/shields
  4. confirmed Auto-redirect tracking URLs setting is toggled On/Enabled as a default
  5. confirmed Enable support for bypassing top-level redirect tracking URLs.' sub label text with Learn more more link displayed
  6. clicked on Learn more, navigated to https://brave.com/privacy-updates/11-debouncing/
  7. visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
  8. click Run for all the conditions (Default, Base 64, Regex & Regex (multi)
  9. click other site and Run the same conditions

Confirmed redirecting worked as expected with Auto-redirect tracking URLs default setting

steps 4-5 step 6 step 8 step 9
Screen Shot 2023-01-17 at 5 50 25 PM Screen Shot 2023-01-17 at 5 50 17 PM Screen Shot 2023-01-17 at 5 53 30 PM Screen Shot 2023-01-17 at 5 56 21 PM

Case 2: Disable Auto-redirect tracking URLs - PASSED

  1. Continue from Case 1:
    • Auto-redirect tracking URLs setting in brave://settings/shields enabled
  2. disable Auto-redirect tracking URLs setting
  3. Toggled Auto-redirect tracking URLs to Off/Disabled via brave://settings/shields
  4. visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
  5. click Run for Default condition

Confirmed redirecting didn't work with disabling Auto-redirect tracking URLs pref

step 2 step 3 step 4 ex ex
Screen Shot 2023-01-17 at 6 00 32 PM Screen Shot 2023-01-17 at 6 05 44 PM Screen Shot 2023-01-17 at 6 03 18 PM Screen Shot 2023-01-17 at 6 03 58 PM Screen Shot 2023-01-17 at 6 03 54 PM

@stephendonner
Copy link

Verified PASSED using 1.48.134 on a Google Pixel XL (arm64) running Android 9

Shared steps:

  1. installed 1.48.134
  2. launched Brave
  3. tapped to set/unset the respective value for Auto-redirect tracking URLs in Brave Shields & privacy
  4. loaded https://dev-pages.brave.software/navigation-tracking/debouncing.html
  5. clicked on each of the Run buttons
  6. (continue with each case)

Case 1: Enable Auto-redirect tracking URLs (default) - PASSED

observed referrer Auto-redirect... ENABLED
Screenshot_20230122-023106 Screenshot_20230122-023130

Case 2: Disable Auto-redirect tracking URLs - PASSED

observed referrer Auto-redirect... DISABLED
Screenshot_20230122-023310 Screenshot_20230122-023506 (1)

Results for each Run-button press

default base64 regex regex (multi)
Screenshot_20230122-023200 Screenshot_20230122-023208 Screenshot_20230122-023218 Screenshot_20230122-023226

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 25, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 25, 2023

Verification PASSED using

Brave | 1.48.140 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
-- | --
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Linux

Case 1: Enable Auto-redirect tracking URLs - PASSED

  1. Install 1.48.140
  2. launch Brave
  3. open a new-tab
  4. navigate to brave://settings/shields
  5. confirmed Auto-redirect tracking URLs setting is toggled On/Enabled as a default
  6. confirmed Enable support for bypassing top-level redirect tracking URLs.' sub label text with Learn more more link displayed
  7. clicked on Learn more, navigated to https://brave.com/privacy-updates/11-debouncing/
  8. visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
  9. click Run for all the conditions (Default, Base 64, Regex & Regex (multi)
  10. click other site and Run the same conditions

Confirmed redirecting worked as expected with Auto-redirect tracking URLs default setting

step 5-6 step 7 step 9 step 10
image image image image

Case 2: Disable Auto-redirect tracking URLs - PASSED

  1. Continue from Case 1:
    • Auto-redirect tracking URLs setting in brave://settings/shields enabled
  2. disable Auto-redirect tracking URLs setting
  3. visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
  4. click Run for Default condition

Confirmed redirecting didn't work with disabling Auto-redirect tracking URLs pref

step 2 step 3 step 4 ex ex
image image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment