Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user preference for debounce #15905

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Nov 11, 2022

Resolves brave/brave-browser#24020

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Desktop:

  • Check that it is default on
  • Check that turning the pref off turns off the feature

Android:

  • Check that it is default on
  • Check that turning the pref off turns off the feature
  • Check that turning the feature flag off turns off the feature, and removes the pref from the settings menu

Copy link
Contributor

@pilgrim-brave pilgrim-brave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @bridiver should also look at this

@ShivanKaul ShivanKaul requested review from a team and iefremov as code owners December 2, 2022 22:00
@ShivanKaul ShivanKaul force-pushed the feature/debounce/preference branch 3 times, most recently from 3340296 to d3e8a62 Compare December 2, 2022 22:10
@ShivanKaul ShivanKaul removed request for a team and iefremov December 2, 2022 22:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

⚠️ PR head is an unsigned commit
commit: 4d3a4de7deffe94eff6f44ab5a42bd39eb4ea832
reason: unsigned
Please follow the handbook to configure commit signing
cc: @ShivanKaul

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@ShivanKaul ShivanKaul merged commit d74fa0a into master Dec 9, 2022
@ShivanKaul ShivanKaul deleted the feature/debounce/preference branch December 9, 2022 20:12
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user pref for debouncing feature
4 participants