Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Settings sidebar disappears on narrow screens #24352

Closed
fallaciousreasoning opened this issue Aug 1, 2022 · 2 comments · Fixed by brave/brave-core#16388
Closed

Brave Settings sidebar disappears on narrow screens #24352

fallaciousreasoning opened this issue Aug 1, 2022 · 2 comments · Fixed by brave/brave-core#16388

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Aug 1, 2022

Description

When shrinking the Brave window the settings menu disappears. It looks like it should be moved to a hamburger menu, but no menu becomes visible.

Settings page (981px wide):
image
^ At this size, the side bar is still visible.

Settings page (980px wide):
image
^ However, shrinking the window slightly smaller, the menu disappears. In similar UIs, it would be possible to summon the menu back with a Hamburger button. However, we seem to be missing one.

Steps to Reproduce

  1. Open the settings page.
  2. Shrink the window until the menu disappears

Actual result:

It should still be possible to access other areas of settings.

Expected result:

You are stuck on the currently open settings section. There is no way to access others (beyond resizing the window or searching)

Reproduces how often:

Always

Brave version (info found on brave://version)

1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)

I think this has been around for longer though. Present on at least Windows & Linux. Probably not a problem on Android 😆

@rebron

@Tol0kk
Copy link

Tol0kk commented Aug 24, 2022

Same issues 👍

@stephendonner
Copy link

Verified PASSED using

Brave | 1.54.85 Chromium: 115.0.5790.56 (Official Build) beta (64-bit)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | Windows 10 Version 22H2 (Build 19045.3155)

Followed the steps to reproduce from #24352 (comment)

Confirmed that, at all window sizes, I get the nav menu icon appearing, which opens the navigation menu, when clicked

example example example example
image (2) image (3) image (4) image

@rebron rebron changed the title Brave Settings Sidebar Disappears on Narrow Screens Brave Settings sidebar disappears on narrow screens Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants