Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 105 to Chromium 106 #24517

Closed
cdesouza-chromium opened this issue Aug 8, 2022 · 6 comments · Fixed by brave/brave-core#14529
Closed

Upgrade from Chromium 105 to Chromium 106 #24517

cdesouza-chromium opened this issue Aug 8, 2022 · 6 comments · Fixed by brave/brave-core#14529
Assignees

Comments

@cdesouza-chromium
Copy link
Contributor

cdesouza-chromium commented Aug 8, 2022

Upgrade from Chromium 105 to Chromium 106.

https://chromium.googlesource.com/chromium/src/+log/105.0.5195.127..106.0.5249.40/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Color scheme (omnibox)
  • History page
  • Content settings
  • Bookmarks
  • Settings UI
  • Cookies
  • Brave Wallet functionality needs a regression test due to internal changes regarding permissions
  • Multiple profiles
  • First run dialog
  • Side panel
  • New tab page

Android Affected areas:

  • Autoplay setting
  • Colors of controls in settings
  • Sharing hub
  • Send tab to another device
  • Bottom toolbar controls
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 19, 2022

Verification PASSED on

Brave | 1.45.54 Chromium: 106.0.5249.40 (Official Build) nightly (64-bit)
-- | --
Revision | fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS | Windows 10 Version 21H2 (Build 19044.2006)

Color scheme (omnibox)_PASSED
  • Verified that omnibox color scheme is shown as expected in focused/not focused in light theme
  • Verified that omnibox color scheme is shown as expected in focused/not focused in dark theme

Light theme

focused not focused
image image

Dark theme

focused not focused
image image
History page_PASSED
  • Confirmed that history of all the visited websites is listed in brave://history
  • Confirmed that brave://history UI looks expected
  • Confirmed that user can search the specific brave history via Search option
  • Confirmed that imported browser history is shown in brave is as expected
Example Example Example Example
image image image image
Content settings_PASSED
  • Confirmed content settings are working as expected

1. Block cookies content settings

  • Open a site cnn.com
  • Open content settings for cnn.com
  • Block content settings for Location and Window management
  • Reload cnn.com
  • Ensured that Location and Window management permission are blocked for cnn.com
  • Open brave://settings/cookies and Block all cookies
  • Reload cnn.com and ensured that all cookies are blocked on cnn.com
Example Example Example Example Example
image image image image image

2. Block scripts content settings

  • Block the java scripts for a site via brave://settings/content/javascript
  • Open the site ensured Java scripts blocked for the site
  • Open a bunch of websited and ensured java script is not blocked
Example Example Example
image image image

3. Block autoplay global settings

  • Block the autoplay content global settings via brave://settings/content/autoplay
  • Open youtube.com and ensured no videos are autoplayed
  • Click on a video and play the video manully, wait till the 1st video ends
  • Ensured 2nd video is not autoplayed
Bookmarks_PASSED
  • Confirmed user can add/edit/delete the bookmarks
  • Confirmed bookmarks can be imported via NTP, brave://settings/importData, Hamburger menu - import bookmarks option and brave://bookmarks/ - Import bookmarks
  • Confirmed imported bookmarks can be opened in PT, new window, new tab and in a regular window
  • Confirmed that imported bookmarks are shown in Private and Tor window new tabs
Example Example Example
image image image
Settings UI_PASSED
  • Verified that click on each settings in brave://settings redirected to the intended page
  • Verified the brave://settings UI and ensured UI looks good
  • Verified the icons in the brave://settings page and ensured icons are shown as expected in each settings page
  • Additional testing on settings is covered in "Settings comparision" section
Cookies_PASSED
  • Ensured that cookies are retained in an upgraded profile
  • Ensured cookies settings are working as expected
  • Ensured local and global cookies shield settings are working as expected

Case 1:

  • Open a site cnn.com
  • Open content settings for cnn.com
  • Open brave://settings/cookies and Block all cookies
  • Reload cnn.com and ensured that all cookies are blocked on cnn.com
  • Open brave://settings/cookies and Allow all cookies
  • Reload cnn.com and ensured that all cookies are allowed on cnn.com
Example Example
image image
Multiple profiles_PASSED
  • Confirmed that user can create the multiple profiles (e.g Profile 1 and Profile 2)
  • Change the brave://settings and import bookmarks and add extensions in Profile 1
  • Ensured that changes made in settings in Profile 1 are NOT reflected in Profile 2
  • Ensured that the bookmarks and extensions are NOT reflected in Profile 2
  • Enable rewards and update the rewards settings in brave://rewards in Profile 1
  • Ensured that updated rewards settings are specific to profile 1 and are not reflected in Profile 2
First run dialog_PASSED
  • Confirmed first run dialog is shown when brave is launched in a clean install
  • Confirmed that the dialog content is as expected
  • Confirmed click on Set Brave as default button in first-run dialog set the brave as the default browser and Make Default is removed from the brave://settings/getStarted
  • Confirmed click on the Maybe later button in the first-run dialog doesn't set the brave as the default browser and the Make Default option is shown in the brave://settings/getStarted
  • Confirmed click on x close button in first-run dialog and doesn't set the brave as the default browser and Make Default is shown in the brave://settings/getStarted
  • Confirmed that the user can set the brave as default browser by clicking on the Make Default option is shown in the brave://settings/getStarted
    image
Side panel_PASSED
  • Confirmed that sidebar is shown by default in the nightly channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
Example Example
image image
New tab page_PASSED
  • Ensured Tops sites can be edit/delete via NTP
  • Ensured that NTP stats can be hidden/shown
  • Ensured that a site can be added via NTP
  • Ensured NTP Widget cards can be added/removed
  • Ensured NTP SI works as expected
  • Ensured that click on settings (bookmarks, history, settings and brave talk) shortcuts works as expected
  • Ensured that the existing features upload your own and Brave background works as expected
  • Confirmed that NTP SI are shown in the order 2, 4, 8 tabs
  • Confirmed that user can select the solid background for NTP
  • Confirmed that user can choose the induvidual solid background via NTP
  • Confirmed that same solid background is shown on each the NTP when the induvidual solid background is selected
  • Confirmed that the differenet solid background is shown on each the NTP when Refresh on every new tab switch is ON
  • Confirmed that user can select the gradient background for NTP
  • Confirmed that user can choose the induvidual gradient background via NTP
  • Confirmed that same gradient background is shown on each the NTP when the induvidual gradient background is selected
  • Confirmed that the differenet gradient background is shown on each the NTP when Refresh on every new tab switch is ON
  • Encountered Bandwidth stats is not shown clearly when blue Gradients/Solid background color is selected #25392, Trackers & ads blocked stats is not shown clearly in NTP when a Gradient/Solid color is selected #25393 and Background Selection state is wrong when SI background is shown #25398

Settings comparison

Verified that the Language settings are updated as part of CR 106
image
Verified that content additional setting is renamed as Windows management as part of CR 106
image
New settigs Tab hover mode and Side panel settings are added as part of Brave in nightly (1.45.x) which are already merged in Beta (1.44.x)
image
Verified that Reading list sync data is been added in brave://sync as part of brave
image
Verified the each settings in brave://settings page and ensured each settings works as expected

Components updater

1.43.93 Chromium: 105.0.5195.127 1.45.54 Chromium: 106.0.5249.40
image image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@srirambv
Copy link
Contributor

srirambv commented Sep 19, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.45.44 x64 build

Autoplay setting - Passed
  • Verified setting is disabled by default
  • Verified enabling setting blocks autoplay on all websites
  • Verified adding an Allow exclusion list only allows those webpages to autoplay
  • Verified adding a Block exclusion list blocks only those webpages from autoplay but allows other webpages to autoplay
Colors of controls in settings - Passed
  • Verified control button colous are visible on both dark/light theme
image image image image
image image image image
Sharing hub - Passed
  • Verified Google Sharing hub is show by default when Share button is clicked from menu/URL bar
  • Verified Disable Sharing hub is disabled by default
  • Verified enabling Disable Sharing hub doesn't prompt for restart
  • Verified enabling Disable Sharing hub causes to show Android Share menu rather than Google Sharing hub
Send tab to another device - Partial Pass
Bottom toolbar controls - Passed
  • Verified bottom toolbar is enabled by default
  • Verified buttons on bottom toolbar work as expected
  • Verified long press on buttons shows context menu/tooltip where applicable
  • Verified no crash when pressing any buttons on bottom toolbar
  • Verified able to disable bottom toolbar via settings
  • Verified able to open tab tray via bottom toolbar
  • Verified able to open home page when tapped on home button
  • Verified able to open a new tab with + button when home button is disabled
  • Verified able to bookmark a page from bottom toolbar
  • Verified able to focus URL bar by pressing the magnifying glass on both NTP/webpage

@rishiraj88
Copy link

Amazing! Kudos!

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.62 Chromium: 106.0.5249.40 (Official Build) nightly (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Windows 11 Version 21H2 (Build 22000.978)
Brave Wallet functionality - Pass
  • Verified able to create wallet
  • Verified able to restore wallet
  • Verified able to import Ledger wallets for Ethereum/Solana/Filecoin
  • Verified able to import Trezor wallet for Ethereum account
  • Verified able to submit a transaction on Ethereum account from imported Ledger wallet
  • Verified able to submit a transaction on Solana Account from imported Ledger wallet
  • Verified able to submit a transaction on Filecoin Account from imported Ledger wallet
  • Verified connecting to Dapps asks for request permission
  • Verified able to sign transactions (Eth sign/Personal Sign/Sign Type Data V3/V4)
  • Verified able to add custom tokens via add prompt
  • Verified able to sign transactions on https://pwgoom.csb.app/ for Solana account

@kjozwiak
Copy link
Member

The above requires 1.44.95 or higher for 1.44.x verification on macOS, Linux & Android Tablet.

@kjozwiak
Copy link
Member

Added QA/No & release-notes/exclude in favour of #25531.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants