-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove speedreader updater component (enabling theme support) #25116
Labels
feature/components
feature/speedreader
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
This was referenced Aug 31, 2022
Verification
Confirmed
|
step 3 | step 4 | step7 | step8 | step10 | step 11 |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verification
|
Brave | 1.46.29 Chromium: 106.0.5249.91 (Official Build) nightly (x86_64) |
---|---|
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707} |
OS | macOS Version 11.7 (Build 20G817) |
Steps:
- installed
1.45.84
- launched Brave
- verified
jicbkmdloagakknpihibphagfckhjdih
is no longer available in the component directory - opened
brave://settings/appearance
and selectedLight
- visited
https://www.bbc.com/travel/article/20220928-mexicos-ancient-unknown-pyramids
- clicked on the
Speedreader
icon - verified the
Light
theme was applied in Speedreader mode to the article - switch to
Dark
theme inbrave://settings/appearance
- returned to the article tab
- verified the
Dark
theme was applied in Speedreader mode to the article - opened
brave://components
Confirmed Brave SpeedReader Updater
component is no longer available
step 3 | step 4 | step 7 | step 8 | step 10 | step 11 |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verified on Google Pixel 3 XL with Android 12 running 1.45.100. Speedreader is not available on Android yet (#22968) however, confirmed that chrome://components does not show Speedreader component: |
Verification passed on
Steps:
Confirmed
|
step 3 | step 4 | step 7 | step 8 | step 10 | step 11 |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/components
feature/speedreader
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/include
The
Brave Speedreader Updater
component (jicbkmdloagakknpihibphagfckhjdih
) only ships two data files in its CRX -content-stylesheet.css
andspeedreader-updater.dat
.The
.dat
file is completely unused, since Speedreader has been updated to no longer use the adblock list-based backend.content-stylesheet.css
is still used to override the style inbrave-core
, but it does so unconditionally even though there is already a speedreader stylesheet bundled insidebrave-core
. The stylesheet is now stable enough to not need to be updated dynamically, so it should be safe to remove this as well.The stylesheet currently shipped by the component updater is fairly old and there is a PR (brave-experiments/SpeedReader#36) to update it to match the current version in
brave-core
, enabling theme support. Merging this will make themes work without requiring the component at all.Once this has enough roll-out, we should remove the speedreader component from
brave-core-crx-packager
as well.The text was updated successfully, but these errors were encountered: