Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect VPN tunnel automatically after split tunnel #24576

Closed
deeppandya opened this issue Aug 10, 2022 · 2 comments · Fixed by brave/brave-core#14581
Closed

Connect VPN tunnel automatically after split tunnel #24576

deeppandya opened this issue Aug 10, 2022 · 2 comments · Fixed by brave/brave-core#14581

Comments

@deeppandya
Copy link

This issue is the follow up issue to #22938. With this issue we start the tunnel right away after split tunnel change without user interaction.

@deeppandya deeppandya added QA/Yes OS/Android Fixes related to Android browser functionality feature/vpn labels Aug 10, 2022
@deeppandya deeppandya added this to the 1.44.x - Nightly milestone Aug 10, 2022
@deeppandya deeppandya self-assigned this Aug 10, 2022
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 29, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 29, 2022

Verified on Samsung Galaxy S21 running Android 12 using the following build(s):

Brave	1.43.83 Chromium: 105.0.5195.68 (Official Build) (64-bit) 
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	Android 12; Build/SP1A.210812.016

Testing based on Test Plan in brave/brave-core#14581 (comment)

Default State:

  • Verified split tunneling is not enabled if there is no VPN profile installed.
  • Verified split tunneling is not enabled if user resets configuration via Settings > Brave Firewall + VPN > Reset Configuration

0

Upgraded Profile

  • Verified Split Tunneling option is enabled when upgraded app with an existing VPN profile.
  • Verified user is able to modify the Split tunneling settings on an upgraded profile.
  • Verified apps excluded will bypass VPN

Split Tunneling when VPN Enabled:

  • Confirmed when user excludes apps from the VPN under Split Tunneling option, profile is automatically updated without user interaction, connection is not interrupted.
  • Confirmed user is abled to remove apps from the Excluded Apps list. It will only take effect if user saves.
  • Confirmed apps that user adds to Excluded Apps on Split tunneling page will bypass the VPN.
  • Confirmed that apps will not be saved if user selects apps into Excluded Apps list but closes page without saving.
  • Confirmed that toggling the VPN off/on via the settings menu, notification tray or the brave hamburger menu will not change state of the Excluding Apps list.
  • Confirmed when user hits show system apps CTA, system apps list will populate.
  • Confirmed user is able to add 25 items into Exclude Apps list under Split Tunneling.
Selected Host location Excluded App Included App
screenshot-1661790374174 screenshot-1661790169134 screenshot-1661790362022

Split Tunneling when VPN Disabled:

  • Confirmed user is able to app/remove apps to the Excluded Apps list when VPN is disabled. Enabling VPN will automatically launch new profile, establish connection.
  • Confirmed user is able to add/remove system apps from Exluded Apps list.
  • Confirmed user is able to remove all apps previous saved from the Excluded list successfully.
Example Example Example
screenshot-1661789922095 screenshot-1661789931063 screenshot-1661789943419

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 29, 2022

Verifiied on Samsung Galaxy Tab S7 running Android 12 using the following build(s):

Brave	1.43.83 Chromium: 105.0.5195.68 (Official Build) (64-bit) 
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	Android 12; Build/SP1A.210812.016

Testing based on Test Plan in brave/brave-core#14581 (comment)

Default State:

  • Verified split tunneling is not enabled if there is no VPN profile installed.
  • Verified split tunneling is not enabled if user resets configuration via Settings > Brave Firewall + VPN > Reset Configuration

Upgraded Profile

  • Verified Split Tunneling option is enabled when upgraded app with an existing VPN profile.
  • Verified user is able to modify the Split tunneling settings on an upgraded profile.
  • Verified apps excluded will bypass VPN

Split Tunneling when VPN Enabled:

  • Confirmed when user excludes apps from the VPN under Split Tunneling option, profile is automatically updated without user interaction, connection is not interrupted.
  • Confirmed user is abled to remove apps from the Excluded Apps list. It will only take effect if user saves.
  • Confirmed apps that user adds to Excluded Apps on Split tunneling page will bypass the VPN.
  • Confirmed that apps will not be saved if user selects apps into Excluded Apps list but closes page without saving.
  • Confirmed that toggling the VPN off/on via the settings menu, notification tray or the brave hamburger menu will not change state of the Excluding Apps list.
  • Confirmed when user hits show system apps CTA, system apps list will populate.
  • Confirmed user is able to add 25 items into Exclude Apps list under Split Tunneling.

Split Tunneling when VPN Disabled:

  • Confirmed user is able to app/remove apps to the Excluded Apps list when VPN is disabled. Enabling VPN will automatically launch new profile, establish connection.
  • Confirmed user is able to add/remove system apps from Excluded Apps list.
  • Confirmed user is able to remove all apps previous saved from the Excluded list successfully.
Option with VPN Profile Excluded App (DuckDuckgo) Allowed apps (DuckDuckGo) No Profile (Default State) Long List
screenshot-1661797907845 screenshot-1661799712728 screenshot-1661799909762 screenshot-1661800045486 screenshot-1661800378564

@Uni-verse Uni-verse added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants