Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tunnel follow up #14581

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Split tunnel follow up #14581

merged 2 commits into from
Aug 11, 2022

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Aug 10, 2022

Resolves brave/brave-browser#24576

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

General points for split tunnel :

  1. Split tunnel should not be shown if user doesn't have any vpn profile.
  2. if vpn is enabled and user tries to exclude the app and press save, VPN should be connected automatically with updated profile with out user interaction.
  3. if vpn is disabled and user tries to exclude the app and press save, profile should be updated in the background. When user tries to connect to the vpn, vpn should be connected with new profile.

Plan :
Follow the same test plan from : brave/brave-browser#24576

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 10, 2022
@deeppandya deeppandya added this to the 1.44.x - Nightly milestone Aug 10, 2022
@deeppandya deeppandya self-assigned this Aug 10, 2022
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya deeppandya merged commit 3a867d6 into master Aug 11, 2022
@deeppandya deeppandya deleted the split_tunnel_follow_up branch August 11, 2022 14:00
brave-builds pushed a commit that referenced this pull request Aug 11, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 25, 2022

Verified on Samsung Galaxy S21 using build version:

Brave	1.45.1 Chromium: 105.0.5195.37 (Official Build) canary (64-bit) 
Revision	5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS	Android 12; Build/SP1A.210812.016

VPN Enabled:

  • Excluding an app and saving will update the VPN connection automatically without user interaction.
  • User is able to include an app and save and VPN connection will update automatically.

VPN Disabled:

  • User is able to include and exclude apps under split tunneling and the VPN connection will update automatically if user enables VPN in setting.
  • User is able to include/exclude system apps.

Split Tunneling:

  • Split tunneling should not be shown if user doesn't have any vpn profile.
  • Verified apps in the exclude list under split tunneling will not work with the VPN.
  • Verified removing apps under split tunneling while VPN is running will update the profile automatically and also have the VPN settings take effect.
Example Example
screenshot-1661468200667 screenshot-1661468232237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect VPN tunnel automatically after split tunnel
3 participants