Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Brave Ads creative instance per hour frequency cap for New Tab Page ads #24820

Closed
tmancey opened this issue Aug 19, 2022 · 1 comment · Fixed by brave/brave-core#14726
Closed

Remove Brave Ads creative instance per hour frequency cap for New Tab Page ads #24820

tmancey opened this issue Aug 19, 2022 · 1 comment · Fixed by brave/brave-core#14726
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.43.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 19, 2022

No description provided.

@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Aug 19, 2022
@tmancey tmancey self-assigned this Aug 19, 2022
@tmancey tmancey mentioned this issue Aug 19, 2022
Merged
25 tasks
@tmancey tmancey added enhancement and removed bug labels Aug 19, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 22, 2022
@tmancey tmancey mentioned this issue Aug 23, 2022
Merged
4 tasks
@btlechowski
Copy link

Verification passed on

Brave 1.43.82 Chromium: 105.0.5195.58 (Official Build) (64-bit)
Revision 1907e1693887af4463221a10247360b7a056db49-refs/branch-heads/5195_47@{#3}
OS Ubuntu 18.04 LTS

Verified creative instance per hour frequency cap are not applied

[13642:13642:0826/211635.794455:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[13642:13642:0826/211635.820480:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[13642:13642:0826/211635.890750:VERBOSE1:seen_advertisers.h(30)] All new_tab_page_ad advertisers have been shown, so round robin
[13642:13642:0826/211635.890965:VERBOSE1:client_state_manager.cc(461)] Resetting seen new_tab_page_ad advertisers
[13642:13642:0826/211635.891216:VERBOSE2:priority.h(34)] 2 ads with a priority of 1 in bucket 1
[13642:13642:0826/211635.891287:VERBOSE1:new_tab_page_ad.cc(61)] Opportunity arose to serve a new tab page ad
[13642:13642:0826/211635.891369:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 2 eligible ads
[13642:13642:0826/211635.891444:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: be5b4ca6-6aef-48ef-ae02-c361d68c3d92
  creativeInstanceId: 276926f3-c0cf-4ac9-bb86-e10ea6ba7336
  creativeSetId: 0628e2e2-af4e-4f2d-adc4-1ee288c659db
  campaignId: 0f614b95-5003-4603-b7f7-1aa8361f6a67
  advertiserId: 3cd5b014-09e0-4d02-a985-f5f7be0ec59a
  segment: untargeted
  companyName: Rugfools 
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/f756a42c-6232-4c5b-be6f-3619de34b235.png
  alt: Rugfools - Get free Rugfolls for holding Color NFTs, 30% discount only for the Brave. - Mint now
  targetUrl: https://www.rugfools.com/mint-colors?utm_source=brave&utm_medium=braveSponsoredImage&utm_campaign=braveSIAug26
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/407cec9a-78b0-45e1-b57d-0d6e77cad0a9.jpg
    focalPoint:
      x: 2145
      y: 720
[13642:13642:0826/211635.909401:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id be5b4ca6-6aef-48ef-ae02-c361d68c3d92 and creative instance id 276926f3-c0cf-4ac9-bb86-e10ea6ba7336
[13642:13642:0826/211635.931720:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

[13642:13642:0826/211916.125696:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[13642:13642:0826/211916.129449:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[13642:13642:0826/211916.137122:VERBOSE1:seen_advertisers.h(30)] All new_tab_page_ad advertisers have been shown, so round robin
[13642:13642:0826/211916.141585:VERBOSE1:client_state_manager.cc(461)] Resetting seen new_tab_page_ad advertisers
[13642:13642:0826/211916.141991:VERBOSE2:priority.h(34)] 1 ads with a priority of 1 in bucket 1
[13642:13642:0826/211916.142091:VERBOSE1:new_tab_page_ad.cc(61)] Opportunity arose to serve a new tab page ad
[13642:13642:0826/211916.142206:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 1 eligible ads
[13642:13642:0826/211916.142316:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: 55570457-dfd5-4c1b-b6d1-1cc16d2b77dd
  creativeInstanceId: 586f3178-5f6a-433e-b18a-b0fab27cbfd7
  creativeSetId: 0628e2e2-af4e-4f2d-adc4-1ee288c659db
  campaignId: 0f614b95-5003-4603-b7f7-1aa8361f6a67
  advertiserId: 3cd5b014-09e0-4d02-a985-f5f7be0ec59a
  segment: untargeted
  companyName: Rugfools 
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/f756a42c-6232-4c5b-be6f-3619de34b235.png
  alt: Rugfools - Get free Rugfolls for holding Color NFTs, 30% discount only for the Brave. - Mint now
  targetUrl: https://www.rugfools.com/mint-colors?utm_source=brave&utm_medium=braveSponsoredImage&utm_campaign=braveSIAug26
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/99dc736f-c6cc-4b15-8b9a-00cacfc44471.jpg
    focalPoint:
      x: 1280
      y: 720
[13642:13642:0826/211916.158397:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 55570457-dfd5-4c1b-b6d1-1cc16d2b77dd and creative instance id 586f3178-5f6a-433e-b18a-b0fab27cbfd7
[13642:13642:0826/211916.177531:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

[13642:13642:0826/212032.155486:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[13642:13642:0826/212032.158790:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[13642:13642:0826/212032.166793:VERBOSE1:seen_advertisers.h(30)] All new_tab_page_ad advertisers have been shown, so round robin
[13642:13642:0826/212032.166985:VERBOSE1:client_state_manager.cc(461)] Resetting seen new_tab_page_ad advertisers
[13642:13642:0826/212032.171807:VERBOSE1:seen_ads.h(30)] All new_tab_page_ad ads have been shown, so round robin
[13642:13642:0826/212032.172162:VERBOSE1:client_state_manager.cc(424)] Resetting seen new_tab_page_ads
[13642:13642:0826/212032.177623:VERBOSE2:priority.h(34)] 2 ads with a priority of 1 in bucket 1
[13642:13642:0826/212032.178696:VERBOSE1:new_tab_page_ad.cc(61)] Opportunity arose to serve a new tab page ad
[13642:13642:0826/212032.178937:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 2 eligible ads
[13642:13642:0826/212032.179147:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: d044ae51-e063-4f35-8a4a-d1b17085f1c0
  creativeInstanceId: 5fb0f779-a858-45d7-93b7-7223c6e0f687
  creativeSetId: 0628e2e2-af4e-4f2d-adc4-1ee288c659db
  campaignId: 0f614b95-5003-4603-b7f7-1aa8361f6a67
  advertiserId: 3cd5b014-09e0-4d02-a985-f5f7be0ec59a
  segment: untargeted
  companyName: Rugfools 
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/f756a42c-6232-4c5b-be6f-3619de34b235.png
  alt: Rugfools - Get free Rugfolls for holding Color NFTs, 30% discount only for the Brave. - Mint now
  targetUrl: https://www.rugfools.com/mint-colors?utm_source=brave&utm_medium=braveSponsoredImage&utm_campaign=braveSIAug26
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/639e7136-96cb-4eda-aef3-bc952636d5fa.jpg
    focalPoint:
      x: 1280
      y: 720
[13642:13642:0826/212032.233796:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id d044ae51-e063-4f35-8a4a-d1b17085f1c0 and creative instance id 5fb0f779-a858-45d7-93b7-7223c6e0f687
[13642:13642:0826/212032.249178:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

[13642:13642:0826/212203.242865:VERBOSE1:eligible_new_tab_page_ads_v1.cc(38)] Get eligible new tab page ads:
[13642:13642:0826/212203.255505:VERBOSE1:eligible_new_tab_page_ads_v1.cc(161)] Get eligible ads for untargeted segment
[13642:13642:0826/212203.272483:VERBOSE1:seen_advertisers.h(30)] All new_tab_page_ad advertisers have been shown, so round robin
[13642:13642:0826/212203.272797:VERBOSE1:client_state_manager.cc(461)] Resetting seen new_tab_page_ad advertisers
[13642:13642:0826/212203.273143:VERBOSE2:priority.h(34)] 1 ads with a priority of 1 in bucket 1
[13642:13642:0826/212203.273323:VERBOSE1:new_tab_page_ad.cc(61)] Opportunity arose to serve a new tab page ad
[13642:13642:0826/212203.273489:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 1 eligible ads
[13642:13642:0826/212203.273671:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: 95b78d87-1c44-46d2-8772-ebef7ffa1116
  creativeInstanceId: 276926f3-c0cf-4ac9-bb86-e10ea6ba7336
  creativeSetId: 0628e2e2-af4e-4f2d-adc4-1ee288c659db
  campaignId: 0f614b95-5003-4603-b7f7-1aa8361f6a67
  advertiserId: 3cd5b014-09e0-4d02-a985-f5f7be0ec59a
  segment: untargeted
  companyName: Rugfools 
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/f756a42c-6232-4c5b-be6f-3619de34b235.png
  alt: Rugfools - Get free Rugfolls for holding Color NFTs, 30% discount only for the Brave. - Mint now
  targetUrl: https://www.rugfools.com/mint-colors?utm_source=brave&utm_medium=braveSponsoredImage&utm_campaign=braveSIAug26
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/407cec9a-78b0-45e1-b57d-0d6e77cad0a9.jpg
    focalPoint:
      x: 2145
      y: 720
[13642:13642:0826/212203.296153:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 95b78d87-1c44-46d2-8772-ebef7ffa1116 and creative instance id 276926f3-c0cf-4ac9-bb86-e10ea6ba7336
[13642:13642:0826/212203.314117:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Remove Brave Ads creative instance per hour frequency cap for New Tab Page ads brave/brave-core
4 participants
@tmancey @kjozwiak @btlechowski @brave-builds