Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Brave Ads creative instance per hour frequency cap for New Tab Page ads #14726

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Remove Brave Ads creative instance per hour frequency cap for New Tab Page ads #14726

merged 1 commit into from
Aug 22, 2022

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 19, 2022

Resolves brave/brave-browser#24820

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm a new tab page ad with the same creative instance id can be seen more than once per hour (other frequency caps still apply).

@tmancey tmancey self-assigned this Aug 19, 2022
@tmancey tmancey requested a review from a team as a code owner August 19, 2022 18:45
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 19, 2022

@aseren, this frequency cap should only affect inline content ads and notification ads

@tmancey tmancey merged commit d576db1 into master Aug 22, 2022
@tmancey tmancey deleted the issues/24820 branch August 22, 2022 13:40
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 22, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.44.63 Chromium: 104.0.5112.102 (Official Build) nightly (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Ubuntu 18.04 LTS

Verified creative instance per hour frequency cap are not applied

[8662:8662:0823/231020.431569:VERBOSE1:eligible_new_tab_page_ads_v1.cc(39)] Get eligible new tab page ads:
[8662:8662:0823/231020.454256:VERBOSE1:eligible_new_tab_page_ads_v1.cc(168)] Get eligible ads for untargeted segment
[8662:8662:0823/231020.468240:VERBOSE2:priority.h(34)] 4 ads with a priority of 1 in bucket 1
[8662:8662:0823/231020.468364:VERBOSE1:new_tab_page_ad.cc(64)] Opportunity arose to serve a new tab page ad
[8662:8662:0823/231020.468542:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 4 eligible ads
[8662:8662:0823/231020.468636:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: 290d2f84-5c11-4c23-98b3-525c5f8451d9
  creativeInstanceId: a0568a26-660f-4a92-ba4b-f338ebc5e37b
  creativeSetId: b5fc0cfd-5b31-4434-9312-88dcd1bf93eb
  campaignId: 6326986b-e3cf-496d-a36f-87a010da3a60
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/00576d29-1a14-4057-9eb1-4a167483ee31.png
  alt: Brave Firewall + VPN - Encrypt and protect everything you do online. Now available on iOS and Android.
  targetUrl: https://brave.com/firewall-vpn/?source=sponsoredimage20220823
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/6e845c64-0e1a-4198-b622-9c89a8d9b9d5.jpg
    focalPoint:
      x: 1280
      y: 720
[8662:8662:0823/231020.482323:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 290d2f84-5c11-4c23-98b3-525c5f8451d9 and creative instance id a0568a26-660f-4a92-ba4b-f338ebc5e37b
[8662:8662:0823/231020.502612:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event



[8662:8662:0823/231847.550366:VERBOSE1:eligible_new_tab_page_ads_v1.cc(39)] Get eligible new tab page ads:
[8662:8662:0823/231847.564529:VERBOSE1:eligible_new_tab_page_ads_v1.cc(168)] Get eligible ads for untargeted segment
[8662:8662:0823/231847.600871:VERBOSE1:seen_advertisers.h(32)] All new_tab_page_ad advertisers have been shown, so round robin
[8662:8662:0823/231847.601006:VERBOSE1:client_state_manager.cc(464)] Resetting seen new_tab_page_ad advertisers
[8662:8662:0823/231847.601329:VERBOSE2:priority.h(34)] 3 ads with a priority of 1 in bucket 1
[8662:8662:0823/231847.601396:VERBOSE1:new_tab_page_ad.cc(64)] Opportunity arose to serve a new tab page ad
[8662:8662:0823/231847.601447:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 3 eligible ads
[8662:8662:0823/231847.601514:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: 940bfa20-364c-4b5d-824a-9b9315870d55
  creativeInstanceId: b430641c-2466-413d-8aa4-eadd03f74a02
  creativeSetId: b5fc0cfd-5b31-4434-9312-88dcd1bf93eb
  campaignId: 6326986b-e3cf-496d-a36f-87a010da3a60
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/00576d29-1a14-4057-9eb1-4a167483ee31.png
  alt: Brave Firewall + VPN - Encrypt and protect everything you do online. Now available on iOS and Android.
  targetUrl: https://brave.com/firewall-vpn/?source=sponsoredimage20220823
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/669adf91-a189-45f7-ad05-dba7d11b61bb.jpg
    focalPoint:
      x: 1280
      y: 720
[8662:8662:0823/231847.616065:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 940bfa20-364c-4b5d-824a-9b9315870d55 and creative instance id b430641c-2466-413d-8aa4-eadd03f74a02
[8662:8662:0823/231847.645088:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event


[8662:8662:0823/232025.413319:VERBOSE1:eligible_new_tab_page_ads_v1.cc(39)] Get eligible new tab page ads:
[8662:8662:0823/232025.420404:VERBOSE1:eligible_new_tab_page_ads_v1.cc(168)] Get eligible ads for untargeted segment
[8662:8662:0823/232025.427598:VERBOSE1:seen_advertisers.h(32)] All new_tab_page_ad advertisers have been shown, so round robin
[8662:8662:0823/232025.428076:VERBOSE1:client_state_manager.cc(464)] Resetting seen new_tab_page_ad advertisers
[8662:8662:0823/232025.428660:VERBOSE2:priority.h(34)] 2 ads with a priority of 1 in bucket 1
[8662:8662:0823/232025.429722:VERBOSE1:new_tab_page_ad.cc(64)] Opportunity arose to serve a new tab page ad
[8662:8662:0823/232025.430284:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 2 eligible ads
[8662:8662:0823/232025.430891:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: 5c660a31-3d8e-4abe-9943-0b2abd9578e4
  creativeInstanceId: db170e5d-e110-4260-9498-b9b045e03dff
  creativeSetId: b5fc0cfd-5b31-4434-9312-88dcd1bf93eb
  campaignId: 6326986b-e3cf-496d-a36f-87a010da3a60
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/00576d29-1a14-4057-9eb1-4a167483ee31.png
  alt: Brave Firewall + VPN - Encrypt and protect everything you do online. Now available on iOS and Android.
  targetUrl: https://brave.com/firewall-vpn/?source=sponsoredimage20220823
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/6e845c64-0e1a-4198-b622-9c89a8d9b9d5.jpg
    focalPoint:
      x: 1280
      y: 720
[8662:8662:0823/232025.439207:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id 5c660a31-3d8e-4abe-9943-0b2abd9578e4 and creative instance id db170e5d-e110-4260-9498-b9b045e03dff
[8662:8662:0823/232025.458009:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event


[8662:8662:0823/232208.667046:VERBOSE1:eligible_new_tab_page_ads_v1.cc(39)] Get eligible new tab page ads:
[8662:8662:0823/232208.678906:VERBOSE1:eligible_new_tab_page_ads_v1.cc(168)] Get eligible ads for untargeted segment
[8662:8662:0823/232208.692823:VERBOSE1:seen_advertisers.h(32)] All new_tab_page_ad advertisers have been shown, so round robin
[8662:8662:0823/232208.693081:VERBOSE1:client_state_manager.cc(464)] Resetting seen new_tab_page_ad advertisers
[8662:8662:0823/232208.693934:VERBOSE2:priority.h(34)] 1 ads with a priority of 1 in bucket 1
[8662:8662:0823/232208.702309:VERBOSE1:new_tab_page_ad.cc(64)] Opportunity arose to serve a new tab page ad
[8662:8662:0823/232208.702522:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 1 eligible ads
[8662:8662:0823/232208.702737:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: b8853d4d-e28c-4950-aecf-1eabe6d37071
  creativeInstanceId: aacd53d9-0edd-49da-ac03-e4c647226b78
  creativeSetId: b5fc0cfd-5b31-4434-9312-88dcd1bf93eb
  campaignId: 6326986b-e3cf-496d-a36f-87a010da3a60
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/00576d29-1a14-4057-9eb1-4a167483ee31.png
  alt: Brave Firewall + VPN - Encrypt and protect everything you do online. Now available on iOS and Android.
  targetUrl: https://brave.com/firewall-vpn/?source=sponsoredimage20220823
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/669adf91-a189-45f7-ad05-dba7d11b61bb.jpg
    focalPoint:
      x: 1280
      y: 720
[8662:8662:0823/232208.712158:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id b8853d4d-e28c-4950-aecf-1eabe6d37071 and creative instance id aacd53d9-0edd-49da-ac03-e4c647226b78
[8662:8662:0823/232208.725392:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

Verified round robin works

[9932:9932:0824/000718.218859:VERBOSE1:eligible_new_tab_page_ads_v1.cc(39)] Get eligible new tab page ads:
[9932:9932:0824/000718.239114:VERBOSE1:eligible_new_tab_page_ads_v1.cc(168)] Get eligible ads for untargeted segment
[9932:9932:0824/000718.245165:VERBOSE1:seen_advertisers.h(32)] All new_tab_page_ad advertisers have been shown, so round robin
[9932:9932:0824/000718.245278:VERBOSE1:client_state_manager.cc(464)] Resetting seen new_tab_page_ad advertisers
[9932:9932:0824/000718.245715:VERBOSE1:seen_ads.h(30)] All new_tab_page_ad ads have been shown, so round robin
[9932:9932:0824/000718.245772:VERBOSE1:client_state_manager.cc(427)] Resetting seen new_tab_page_ads
[9932:9932:0824/000718.245947:VERBOSE2:priority.h(34)] 3 ads with a priority of 1 in bucket 1
[9932:9932:0824/000718.245995:VERBOSE1:new_tab_page_ad.cc(64)] Opportunity arose to serve a new tab page ad
[9932:9932:0824/000718.246108:VERBOSE1:new_tab_page_ad_serving.cc(89)] Found 3 eligible ads
[9932:9932:0824/000718.246197:VERBOSE1:new_tab_page_ad_serving.cc(138)] Served new tab page ad:
  placementId: a8f25cc3-5299-45f5-81f1-329ab6d50602
  creativeInstanceId: db170e5d-e110-4260-9498-b9b045e03dff
  creativeSetId: b5fc0cfd-5b31-4434-9312-88dcd1bf93eb
  campaignId: 6326986b-e3cf-496d-a36f-87a010da3a60
  advertiserId: 216c5e8c-434d-4c72-a9c5-3a11343dde48
  segment: untargeted
  companyName: Brave
  imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/00576d29-1a14-4057-9eb1-4a167483ee31.png
  alt: Brave Firewall + VPN - Encrypt and protect everything you do online. Now available on iOS and Android.
  targetUrl: https://brave.com/firewall-vpn/?source=sponsoredimage20220823
  wallpaper:
    imageUrl: https://mobile-data.s3.brave.com/assets/ntp-si/6e845c64-0e1a-4198-b622-9c89a8d9b9d5.jpg
    focalPoint:
      x: 1280
      y: 720
[9932:9932:0824/000718.274580:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id a8f25cc3-5299-45f5-81f1-329ab6d50602 and creative instance id db170e5d-e110-4260-9498-b9b045e03dff
[9932:9932:0824/000718.290664:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event

@tmancey tmancey mentioned this pull request Aug 23, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseren aseren aseren approved these changes

Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging this pull request may close these issues.

Remove Brave Ads creative instance per hour frequency cap for New Tab Page ads
3 participants
@tmancey @btlechowski @aseren