Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update introductory graphic for Reading list panel #24927

Closed
GeetaSarvadnya opened this issue Aug 24, 2022 · 3 comments · Fixed by brave/brave-core#17605
Closed

Update introductory graphic for Reading list panel #24927

GeetaSarvadnya opened this issue Aug 24, 2022 · 3 comments · Fixed by brave/brave-core#17605

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 24, 2022

Description

Reading list graphics is inherited from chrome

Actual result:

image

Expected result:

See: #24927 (comment)

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.44.64 Chromium: 105.0.5195.37 (Official Build) nightly (64-bit)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS Windows 10 Version 21H2 (Build 19044.1889)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @bradleyrichter

@aguscruiz
Copy link

Already have a design for this, link here: https://www.figma.com/file/xOdKFSr3P5AXSAbP2r8ung/Sidebar-Desktop?node-id=3862%3A70675

image

@stephendonner
Copy link

Verified PASSED using

Brave 1.51.76 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.4 (Build 22F5027f)

Post-fix

Figma spec Light Dark
Screenshot 2023-04-03 at 2 10 20 PM Screenshot 2023-04-03 at 2 02 36 PM Screenshot 2023-04-03 at 2 04 33 PM

Previous

Light Dark
Screenshot 2023-04-03 at 2 12 14 PM Screenshot 2023-04-03 at 2 11 39 PM

@rebron rebron changed the title Reading list graphics is inherited from chrome Update introductory graphic for Reading list panel Apr 4, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.51.87 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2846)
Dark Light
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants