Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show current network and localhost for Filecoin #24947

Closed
srirambv opened this issue Aug 24, 2022 · 1 comment · Fixed by brave/brave-core#14912
Closed

Only show current network and localhost for Filecoin #24947

srirambv opened this issue Aug 24, 2022 · 1 comment · Fixed by brave/brave-core#14912
Assignees
@cypt4
Labels
bug feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 24, 2022 •
edited
Loading

Description

Only show current network and localhost for Filecoin

Steps to Reproduce

  1. Create Wallet and enable testnet networks
  2. Create Filecoin account
  3. Open Filecoin Account, shows Filecoin for all networks

Actual result:

All networks listed for Filecoin

Expected result:

Should only be the current network and Localhost

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Windows 11 Version 21H2 (Build 22000.856)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cypt4 @yrliou
This was referenced Aug 24, 2022
Closed
Closed
@yrliou yrliou added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 25, 2022
@cypt4 cypt4 mentioned this issue Aug 31, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Sep 8, 2022
@cypt4
Various balance fixes for FIL
7102157 
Resolves brave/brave-browser#24947
1) Changed calibration api url
2) Fixed a bug when balance was not loading for mainnet if wallet opened with selected testnet acc.
3) When open account info for filecoin only supported networks are showing for now(mainnet for f* and testnet\localhost for t*).
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 8, 2022
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
  • Verified steps from brave/brave-core#14912
  • Verified only Filecoin for mainnet is shown when account is selected
  • Verified for testenet account it shows both testnet and localhost
  • Verified accounts for Ethereum and Solana works as expected
24947.mp4

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#14912
  • Verified only Filecoin for mainnet is shown when account is selected
  • Verified for testenet account it shows both testnet and localhost
  • Verified accounts for Ethereum and Solana works as expected
24947.mp4

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#14912
  • Verified only Filecoin for mainnet is shown when account is selected
  • Verified for testenet account it shows both testnet and localhost
  • Verified accounts for Ethereum and Solana works as expected
24947.mov

@srirambv srirambv mentioned this issue Oct 20, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
bug feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Various balance fixes for FIL brave/brave-core
4 participants
@yrliou @srirambv @brave-builds @cypt4