Make sidebar item editable #24964

simonhong · 2022-08-25T03:13:06Z

For now, user can't touch each item's properties such as title or url.
User may want to edit them after adding.

For example, we can launch item edit dialog via context menu like topsite tile's one

simonhong · 2022-08-26T00:28:29Z

@aguscruiz ~~I think edit dialog also needs visual feedback when user tries to enter invalid url or alread used url from another sidebar items. Sidebar can't have two different items that uses same url.~~
I think url should not be updated because it's like unique id for each sidebar item.
So, only its title could be editable as I shared demo clips in DM.

fix brave/brave-browser#24964 When user selects edit... context menu for sidebar item, another bubble is launched for getting new url or title. Use the url as a title for sidebar item when title input is empty

stephendonner · 2022-10-06T00:24:43Z

Verified `PASSED` using

Brave	1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (x86_64)
Revision	fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS	macOS Version 11.7 (Build 20G817)

Steps:

installed 1.45.87
launched Brave
loaded bravest.com
loaded brave.com
added both of the above sites to the Sidebar via the + (Add to Sidebar) button
context-clicked on the bravest.com icon and chose Edit
changed the URL to brave.com from bravest.com
clicked on OK
context-clicked on the bravest.com icon again and chose Edit
confirmed the URL remains the original bravest.com

step 5	step 6	step 7a	step 7b	step 9	step 10

simonhong added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. QA/Yes release-notes/include OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Aug 25, 2022

simonhong self-assigned this Aug 25, 2022

simonhong added a commit to brave/brave-core that referenced this issue Aug 25, 2022

WIP: Edit existing sidebar item

080586c

fix brave/brave-browser#24964