Bookmarks menu in macOS menu bar sometimes appears blank

[Brave-Matt]

Description

Some users are reporting that their bookmarks option on the menu bar for macOS does not display their bookmarks for them, despite having bookmarks saved in the browser.

The issue appears to be intermittent and all reports seem to be macOS M1/Monterey builds. May also be a chromium based issue.

Steps to Reproduce

Report 1:

1. open Brave
2. open a new Private Window
3. close Private Window
4. Bookmarks on the title menu are gone.

Report 2:

1. Starting with Brave closed completely, open Brave
2. Check Bookmarks menu and note that it’s the full, proper menu (as opposed to just the Bookmark Manager, Bookmark This Tab, Bookmark All Tabs options)
3. Open new private window
4. Close private window
5. Check bookmarks menu and note that it is now just Bookmark Manager, Bookmark This Tab, and Bookmark All Tabs options

Reproduces how often:

Issue is intermittent

Brave version (brave://version info)

Version 1.43.86
Chromium: 105.0.5195.68 (Official Build) (x86_64)
And higher

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes
  ☝️ Note that due to intermitted-ness, these results may vary

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

User reports:
https://community.brave.com/t/no-bookmarks-in-bookmarks-menu-after-latest-upgrade/428746

[Brave-Matt]

Edited the above issue with steps to reproduce as provided by some of our awesome Community members.

[CFarzaneh]

I'm having this issue. Incognito I see all my bookmarks but not in regular browser mode.

[traut]

Seeing the same issue, Brave version is Version 1.45.113 Chromium: 107.0.5304.62 (Official Build) (arm64), macOS 12.6

[Brave-Matt]

I have more users still reporting this behavior:
https://community.brave.com/t/bookmarks-dropdown-missing/436412/6

[castig]

I'm having this issue — if you need someone to test :)

[opjarretop]

I can confirm this issue as well. [Version 1.45.118 Chromium: 107.0.5304.91 (Official Build) (arm64)](https://brave.com/latest/) macOS 12.6

[ib0ndar]

Version 1.46.110 Chromium: 107.0.5304.110 (Official Build) beta (x86_64) running on macOS 12.6.1 (21G217) (Intel) - the issue persists.

[NickThorne123]

I can confirm on Version 1.46.140 Chromium: 108.0.5359.99 (Official Build) (x86_64)
Monterey MacOS 12.5.1
2018 Intel MBP

Bookmarks are present in Private window, and in Bookmarks Manager.
Have to restart Brave to solve it. Happens about 2x a week.

Is there a log file anywhere that might cast some more light on the issue ?

[kerim]

I can confirm on my M1 MBP

[tripleee]

Another observation: If I keep a private window open (to counteract this bug!) but create a new private window and then close it, the Bookmark menu is empty again. Switching to the other private window I had open all this time as my active focused window and then immediately returning to my regular browser window and activating that brings back the bookmarks. This suggests that perhaps the act of closing a private window specifically is the culprit.

[LucasLarson]

Similar to @tripleee’s experience:

1. two non-private windows open today
2. opened a private window and closed it later
3. found my bookmarks menu empty in my longest-open non-private window
4. opened a new private window and found a complete bookmarks menu
5. closed the private window, and (← this step did not occur)
6. finally, found my bookmarks back to normal everywhere

[swinggraphics]

Still exists in 1.48.164
It seems long as a private window is open, the Bookmarks menu is populated.

[mjr2595]

Issue still persists:
Version 1.49.132 Chromium: 111.0.5563.147 (Official Build) (arm64)

[castig]

Yes

…

On Sun, Apr 2, 2023 at 12:48 PM Michael Raymond ***@***.***> wrote: Issue still persists: Version 1.49.132 Chromium: 111.0.5563.147 (Official Build) (arm64) — Reply to this email directly, view it on GitHub <#25644 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABZ3WMBIGFLKX52QQ2Y7UDW7G3YFANCNFSM6AAAAAAQW7NHAY> . You are receiving this because you commented.Message ID: ***@***.***>

-- Chris Castiglione | castig.org | @castig <http://www.twitter.com/castig> Teacher at OneMonth.com <https://onemonth.com/>

[simonhong]

Upstream issue - chrome also has this issue when brave://flags/#destroy-profile-on-browser-close flag is disabled.
Investigating how to fix this issue..

[castig]

This still isn't working for me. FYI.

…

On Wed, May 3, 2023 at 8:32 AM Simon Hong ***@***.***> wrote: Closed #25644 <#25644> as completed via brave/brave-core#18326 <brave/brave-core#18326>. — Reply to this email directly, view it on GitHub <#25644 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABZ3WPX4TRJPO67FAWOIITXEJNAFANCNFSM6AAAAAAQW7NHAY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Chris Castiglione | castig.org | @castig <http://www.twitter.com/castig> Teacher at OneMonth.com <https://onemonth.com/>

[simonhong]

This still isn't working for me. FYI.
…
On Wed, May 3, 2023 at 8:32 AM Simon Hong @.> wrote: Closed #25644 <#25644> as completed via brave/brave-core#18326 <brave/brave-core#18326>. — Reply to this email directly, view it on GitHub <#25644 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZ3WPX4TRJPO67FAWOIITXEJNAFANCNFSM6AAAAAAQW7NHAY . You are receiving this because you were mentioned.Message ID: @.>
-- Chris Castiglione | castig.org | @castig http://www.twitter.com/castig Teacher at OneMonth.com https://onemonth.com/

@castig It's fixed in brave but it's not yet included to nightly release.
I think next nightly update (1.53.17 or higher) will have this fix.

[tripleee]

This is still broken in production. When can we expect 1.53.17+ to be available as the mainline version?

[simonhong]

This is still broken in production. When can we expect 1.53.17+ to be available as the mainline version?

According to our release schedule, it could be delivered to stable release at June 27, 2023

[stephendonner]

I've had trouble reproducing this, thus far (on macOS, Big Sur), and while I continue to try to reproduce the issue (so I can properly verify the fix), can those here who experienced this issue chime in on whether it's fixed or not?

If you could use a recent build -- such as https://github.com/brave/brave-browser/releases/tag/v1.53.74 -- that would be great, thanks!

[stephendonner]

Verified PASSED using

Brave	1.53.81 Chromium: 114.0.5735.90 (Official Build) beta (x86_64)
Revision	386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS	macOS Version 11.7.7 (Build 20G1345)

1.53.81 (fix)

Followed the steps to reproduce from #25644 (comment) (with additional testing around sessions/state), and could no longer reproduce the issue.

Private window	Normal window

Also confirmed that Guest windows don't show bookmarks, but Private windows with Tor do:

Guest window	Private window with Tor

1.49.132 (bug)

Finally was able to reproduce this using

Brave | 1.49.132 Chromium: 111.0.5563.147 (Official Build) (x86_64)
-- | --
Revision | 029fd65a4dd711d1078468ed2206999cec86066b-refs/branch-heads/5563@{#1239}
OS | macOS Version 11.7.7 (Build 20G1345)

Followed the steps to reproduce from: #25644 (comment)